[ruby-core:56898] [ruby-trunk - Bug #8841][Open] Module#included_modules and prepended modules

[ruby-core:56898] [ruby-trunk - Bug #8841][Open] Module#included_modules and prepended modules

[marcandre (Marc-Andre Lafortune)]

Issue #8841 has been reported by marcandre (Marc-Andre Lafortune).

----------------------------------------
Bug #8841: Module#included_modules and prepended modules
https://bugs.ruby-lang.org/issues/8841

Author: marcandre (Marc-Andre Lafortune)
Status: Open
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Category: core
Target version: next minor
ruby -v: r42735
Backport: 


The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with `include?` that returns true for prepended modules, but not quite consistent with `included` that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of `include?` and `included_modules`.


-- 
http://bugs.ruby-lang.org/

[ruby-core:96348] [Ruby master Bug#8841] Module#included_modules and prepended modules

[mame]

Issue #8841 has been updated by mame (Yusuke Endoh).


Summary:

* `Module#include?` and `Module#included_modules` regard prepended modules as `included` (not well documented)
* `Module#included` is not called when the module is prepended

Is this right?

----------------------------------------
Bug #8841: Module#included_modules and prepended modules
https://bugs.ruby-lang.org/issues/8841#change-83259

* Author: marcandre (Marc-Andre Lafortune)
* Status: Open
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
* ruby -v: r42735
* Backport: 
----------------------------------------
The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with `include?` that returns true for prepended modules, but not quite consistent with `included` that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of `include?` and `included_modules`.



-- 
https://bugs.ruby-lang.org/

[ruby-core:96376] [Ruby master Bug#8841] Module#included_modules and prepended modules

[jean.boussier]

Issue #8841 has been updated by byroot (Jean Boussier).


> Module#included is not called when the module is prepended

I think that's fine, because it calls `Module#prepended`.

> Module#include? and Module#included_modules regard prepended modules as included (not well documented)

That yes:

```ruby
class Base
end

module A
end

module B
end

Base.prepend(A)
Base.include(B)

p Base.included_modules
```

outputs:

```
[A, B, Kernel]
```


----------------------------------------
Bug #8841: Module#included_modules and prepended modules
https://bugs.ruby-lang.org/issues/8841#change-83293

* Author: marcandre (Marc-Andre Lafortune)
* Status: Open
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
* ruby -v: r42735
* Backport: 
----------------------------------------
The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with `include?` that returns true for prepended modules, but not quite consistent with `included` that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of `include?` and `included_modules`.



-- 
https://bugs.ruby-lang.org/

[ruby-core:96891] [Ruby master Bug#8841] Module#included_modules and prepended modules

[matz]

Issue #8841 has been updated by matz (Yukihiro Matsumoto).

Status changed from Open to Closed

This intentional.

Matz.


----------------------------------------
Bug #8841: Module#included_modules and prepended modules
https://bugs.ruby-lang.org/issues/8841#change-83904

* Author: marcandre (Marc-Andre Lafortune)
* Status: Closed
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
* ruby -v: r42735
* Backport: 
----------------------------------------
The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with `include?` that returns true for prepended modules, but not quite consistent with `included` that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of `include?` and `included_modules`.



-- 
https://bugs.ruby-lang.org/

[ruby-core:96916] [Ruby master Bug#8841] Module#included_modules and prepended modules

[ruby-core]

Issue #8841 has been updated by marcandre (Marc-Andre Lafortune).


Thank you.

I clarified the documentation to reflect this.

----------------------------------------
Bug #8841: Module#included_modules and prepended modules
https://bugs.ruby-lang.org/issues/8841#change-83934

* Author: marcandre (Marc-Andre Lafortune)
* Status: Closed
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
* ruby -v: r42735
* Backport: 
----------------------------------------
The documentation for Module#included_modules currently states "Returns the list of modules included in +mod+."

This was never perfectly accurate, as the list also contains modules included in +mod+'s ancestors.

It now also includes prepended modules.

This is consistent with `include?` that returns true for prepended modules, but not quite consistent with `included` that does not get called for prepended modules.

Matz, could you confirm that current behavior is what you want?

If so, we should fix the documentation of `include?` and `included_modules`.



-- 
https://bugs.ruby-lang.org/