* [ruby-core:95696] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7
[not found] <redmine.issue-16293.20191105121436@ruby-lang.org>
@ 2019-11-05 12:14 ` manga.osyo
2019-11-05 12:56 ` [ruby-core:95698] " hsbt
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: manga.osyo @ 2019-11-05 12:14 UTC (permalink / raw)
To: ruby-core
Issue #16293 has been reported by osyo (manga osyo).
----------------------------------------
Feature #16293: Numbered parameter confirmation in Ruby 2.7
https://bugs.ruby-lang.org/issues/16293
* Author: osyo (manga osyo)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error.
* No warning -> No error in the future
* Warning -> Deprecated syntax
* Error -> Error in Ruby 2.7
## Ruby version
```ruby
p RUBY_VERSION
# => "2.7.0"
p RUBY_DESCRIPTION
# => "ruby 2.7.0dev (2019-11-02T06:32:49Z trunk 772b0613c5) [x86_64-linux]"
p RUBY_RELEASE_DATE
# => "2019-11-02"
p RUBY_REVISION
# => "772b0613c583773cd2eda23bce8275926a351e79"
```
## [Log in DevelopersMeeting20190829Japan](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit)
* local variables (parameters and assigned variable) → force warning (Don’t use) on Ruby 2.7 and syntax error on Ruby 3.
* method invocation
* vcall: `x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3.
* vcall: `1.times{ _0 }` → block parameter (incompatibility)
* vcall: `1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3.
* method invocation (`x = _0(), x = foo._0`) → no warning
* method name (`def _0(); end`) → no warning
## Current behavior
```ruby
# No warning
# Defined parameter name `_1`
def hgoe(_1)
end
```
```ruby
def _1
:method
end
# No warning
# Call to method `_1`
x = _1
p x
# => :method
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
```ruby
def _1
:method
end
# Error: ordinary parameter is defined
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# No warning
# Defined local variable
_1 = 42
}
```
```ruby
def _1
:method
end
# No warning
p _1
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
## Proposal
* When deprecated in the future, it is necessary to issue a Warning
* Considering compatibility, make it Warning instead of Error
```ruby
def _1
:method
end
# Warning
# "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" in logs
x = _1
p x
# => :method
# Warning
p eval("_1")
```
```ruby
def _1
:method
end
# Warning
# "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." in logs
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# Warning
_1 = 42
}
```
```ruby
# Warning
# Since local variables are also warnings, formal parameters are also warnings
def hgoe(_1)
end
# NOTE
# `eval("_1")` refers to a dummy argument
def hoge(_1)
p proc {
_1
eval("_1")
}.call 42
end
hoge :argument
# => :argument
```
## Other behavior
* Is there any other syntax to change `No warning` `Warning` `Error` ?
### Example 1. Defined local variable name `_1`
```ruby
# Example 1-1
# Warning : defined local variable
_1 = 42
```
```ruby
# Example 1-2
# No warning : defined method name
def _1
42
end
```
```ruby
# Example 1-3
# No warning : defined parameter name
def hgoe(_1)
end
```
```ruby
# Example 1-4
# In block
proc {
# Warning: `_1' is used as Numbered parameter
_1 = 42
}
# Example 1-5
# In block and used Numbered parameter
proc {
_1
# No warning
_1 = 42
}
```
### Example 2. Refer to local variable `_1` in block
```ruby
_1 = :local_variable
# Example 2-1
# No warning
x = _1
p x
# => :local_variable
# Example 2-2
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 2-3
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 2-4
p proc {
_1
proc {
# No warning
_1
}.call
}.call 42
# => :local_variable
```
### Example 3. Refer to method `_1` in block
```ruby
def _1(a = nil)
:"method#{a}"
end
# Example 3-1
# No warning
x = _1
p x
# => :method
# Example 3-2
# No warning
x = _1 42
p x
# => :method42
# Example 3-3
# No warning
x = _1()
p x
# => :method
# Example 3-4
# Error
p proc { |i| _1 }.call 42
# Example 3-5
# No warning
p proc { |i| _1() }.call 42
# => :method
# Example 3-6
# No warning
p proc { |i| _1 i }.call 42
# => :method42
# Example 3-7
# No warning
p proc { |i| self._1 }.call 42
# => :method
# Example 3-8
# No warning
p proc { _1 }.call 42
# => 42
# Example 3-9
# No warning
p proc { _1 _2 }.call 42, 3
# => method3
# Example 3-10
# No warning
p proc { _1() }.call 42
# => :method
# Example 3-11
# No warning
p proc { self._1 }.call 42
# => :method
```
### Example 4. Defined local variable `_1` and method `_1`
```ruby
def _1(a = nil)
:"method#{a}"
end
_1 = :local_variable
# Example 4-1
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 4-2
# No warning
p proc { |i| _1() }.call 3
# => :method
# Example 4-3
# No warning
p proc { |i| _1 42 }.call 3
# => :method42
# Example 4-4
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 4-5
# No warning
p proc { _1() }.call 3
# => :method
# Example 4-6
# No warning
p proc { _1 42 }.call 3
# => :method42
```
### Example 5. Used `eval("_1")`
* `eval ("_1")` refers to local variables in preference
* The same goes for `binding.local_variable_get(:_1)`
* If local variable `_1` becomes Error, solve it?
* `eval("@1")` is Syntax Error
```ruby
# Example 5-1
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
```
```ruby
# Example 5-2
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
```ruby
_1 = :local_variable
# Example 5-3
# No warning
p eval("_1")
# => :local_variable
# Example 5-4
# No warning
p proc { eval("_1") }.call 42
# => :local_variable
# Example 5-5
# No warning
p proc { _1; eval("_1") }.call 42
# => :local_variable
```
```ruby
# Example 5-6
p proc {
_1
# Error: numbered parameter is already used in
# outer block here
proc { _1 }.call 3
}.call 42
```
```ruby
# Example 5-7
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => 42
```
```ruby
# Example 5-8
_1 = :local_variable
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => :local_variable
```
```ruby
def _1
:method
end
# Example 5-9
# No warning
p _1
# => :method
# Example 5-10
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
# Example 5-11
# No warning
p eval("_1()")
# => :method
# Example 5-12
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
# Example 5-13
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
### Example 6. Used default arguments
```ruby
# Example 6-1
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-2
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# OK
def _1
:method
end
p proc {
_1
eval("_1")
}.call 42
# => 42
```
```ruby
# Example 6-3
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
```ruby
# Example 6-4
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-5
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# Example 6-6
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
### Example 7. Refrer to `_1` in binding.irb
```ruby
# Example 7-1
proc {
_1
# Referencing _1 returns 42
binding.irb
}.call 42
```
```ruby
# Example 7-2
_1 = :local_variable
proc {
_1
# Referencing _1 returns :local_variable
binding.irb
}.call 42
```
Are there other edge cases for Numbered parameter?
Thank you :)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread* [ruby-core:95698] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7
[not found] <redmine.issue-16293.20191105121436@ruby-lang.org>
2019-11-05 12:14 ` [ruby-core:95696] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7 manga.osyo
@ 2019-11-05 12:56 ` hsbt
2019-11-05 13:05 ` [ruby-core:95700] " mame
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: hsbt @ 2019-11-05 12:56 UTC (permalink / raw)
To: ruby-core
Issue #16293 has been updated by hsbt (Hiroshi SHIBATA).
I couldn't understand your request. Please summarize actual and expect behavior with your request.
----------------------------------------
Feature #16293: Numbered parameter confirmation in Ruby 2.7
https://bugs.ruby-lang.org/issues/16293#change-82486
* Author: osyo (manga osyo)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error.
* No warning -> No error in the future
* Warning -> Deprecated syntax
* Error -> Error in Ruby 2.7
## Ruby version
```ruby
p RUBY_VERSION
# => "2.7.0"
p RUBY_DESCRIPTION
# => "ruby 2.7.0dev (2019-11-02T06:32:49Z trunk 772b0613c5) [x86_64-linux]"
p RUBY_RELEASE_DATE
# => "2019-11-02"
p RUBY_REVISION
# => "772b0613c583773cd2eda23bce8275926a351e79"
```
## [Log in DevelopersMeeting20190829Japan](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit)
* local variables (parameters and assigned variable) → force warning (Don’t use) on Ruby 2.7 and syntax error on Ruby 3.
* method invocation
* vcall: `x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3.
* vcall: `1.times{ _0 }` → block parameter (incompatibility)
* vcall: `1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3.
* method invocation (`x = _0(), x = foo._0`) → no warning
* method name (`def _0(); end`) → no warning
## Current behavior
```ruby
# No warning
# Defined parameter name `_1`
def hgoe(_1)
end
```
```ruby
def _1
:method
end
# No warning
# Call to method `_1`
x = _1
p x
# => :method
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
```ruby
def _1
:method
end
# Error: ordinary parameter is defined
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# No warning
# Defined local variable
_1 = 42
}
```
```ruby
def _1
:method
end
# No warning
p _1
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
## Proposal
* When deprecated in the future, it is necessary to issue a Warning
* Considering compatibility, make it Warning instead of Error
```ruby
def _1
:method
end
# Warning
# "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" in logs
x = _1
p x
# => :method
# Warning
p eval("_1")
```
```ruby
def _1
:method
end
# Warning
# "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." in logs
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# Warning
_1 = 42
}
```
```ruby
# Warning
# Since local variables are also warnings, formal parameters are also warnings
def hgoe(_1)
end
# NOTE
# `eval("_1")` refers to a dummy argument
def hoge(_1)
p proc {
_1
eval("_1")
}.call 42
end
hoge :argument
# => :argument
```
## Other behavior
* Is there any other syntax to change `No warning` `Warning` `Error` ?
### Example 1. Defined local variable name `_1`
```ruby
# Example 1-1
# Warning : defined local variable
_1 = 42
```
```ruby
# Example 1-2
# No warning : defined method name
def _1
42
end
```
```ruby
# Example 1-3
# No warning : defined parameter name
def hgoe(_1)
end
```
```ruby
# Example 1-4
# In block
proc {
# Warning: `_1' is used as Numbered parameter
_1 = 42
}
# Example 1-5
# In block and used Numbered parameter
proc {
_1
# No warning
_1 = 42
}
```
### Example 2. Refer to local variable `_1` in block
```ruby
_1 = :local_variable
# Example 2-1
# No warning
x = _1
p x
# => :local_variable
# Example 2-2
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 2-3
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 2-4
p proc {
_1
proc {
# No warning
_1
}.call
}.call 42
# => :local_variable
```
### Example 3. Refer to method `_1` in block
```ruby
def _1(a = nil)
:"method#{a}"
end
# Example 3-1
# No warning
x = _1
p x
# => :method
# Example 3-2
# No warning
x = _1 42
p x
# => :method42
# Example 3-3
# No warning
x = _1()
p x
# => :method
# Example 3-4
# Error
p proc { |i| _1 }.call 42
# Example 3-5
# No warning
p proc { |i| _1() }.call 42
# => :method
# Example 3-6
# No warning
p proc { |i| _1 i }.call 42
# => :method42
# Example 3-7
# No warning
p proc { |i| self._1 }.call 42
# => :method
# Example 3-8
# No warning
p proc { _1 }.call 42
# => 42
# Example 3-9
# No warning
p proc { _1 _2 }.call 42, 3
# => method3
# Example 3-10
# No warning
p proc { _1() }.call 42
# => :method
# Example 3-11
# No warning
p proc { self._1 }.call 42
# => :method
```
### Example 4. Defined local variable `_1` and method `_1`
```ruby
def _1(a = nil)
:"method#{a}"
end
_1 = :local_variable
# Example 4-1
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 4-2
# No warning
p proc { |i| _1() }.call 3
# => :method
# Example 4-3
# No warning
p proc { |i| _1 42 }.call 3
# => :method42
# Example 4-4
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 4-5
# No warning
p proc { _1() }.call 3
# => :method
# Example 4-6
# No warning
p proc { _1 42 }.call 3
# => :method42
```
### Example 5. Used `eval("_1")`
* `eval ("_1")` refers to local variables in preference
* The same goes for `binding.local_variable_get(:_1)`
* If local variable `_1` becomes Error, solve it?
* `eval("@1")` is Syntax Error
```ruby
# Example 5-1
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
```
```ruby
# Example 5-2
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
```ruby
_1 = :local_variable
# Example 5-3
# No warning
p eval("_1")
# => :local_variable
# Example 5-4
# No warning
p proc { eval("_1") }.call 42
# => :local_variable
# Example 5-5
# No warning
p proc { _1; eval("_1") }.call 42
# => :local_variable
```
```ruby
# Example 5-6
p proc {
_1
# Error: numbered parameter is already used in
# outer block here
proc { _1 }.call 3
}.call 42
```
```ruby
# Example 5-7
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => 42
```
```ruby
# Example 5-8
_1 = :local_variable
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => :local_variable
```
```ruby
def _1
:method
end
# Example 5-9
# No warning
p _1
# => :method
# Example 5-10
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
# Example 5-11
# No warning
p eval("_1()")
# => :method
# Example 5-12
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
# Example 5-13
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
### Example 6. Used default arguments
```ruby
# Example 6-1
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-2
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# OK
def _1
:method
end
p proc {
_1
eval("_1")
}.call 42
# => 42
```
```ruby
# Example 6-3
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
```ruby
# Example 6-4
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-5
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# Example 6-6
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
### Example 7. Refrer to `_1` in binding.irb
```ruby
# Example 7-1
proc {
_1
# Referencing _1 returns 42
binding.irb
}.call 42
```
```ruby
# Example 7-2
_1 = :local_variable
proc {
_1
# Referencing _1 returns :local_variable
binding.irb
}.call 42
```
Are there other edge cases for Numbered parameter?
Thank you :)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread* [ruby-core:95700] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7
[not found] <redmine.issue-16293.20191105121436@ruby-lang.org>
2019-11-05 12:14 ` [ruby-core:95696] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7 manga.osyo
2019-11-05 12:56 ` [ruby-core:95698] " hsbt
@ 2019-11-05 13:05 ` mame
2019-11-05 16:18 ` [ruby-core:95703] " shevegen
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: mame @ 2019-11-05 13:05 UTC (permalink / raw)
To: ruby-core
Issue #16293 has been updated by mame (Yusuke Endoh).
It is difficult for me to analyze this ticket, too. Could you write your expectations and the actual results?
```ruby
# expected: warning: `_1' is used as numbered parameter
# actual: no warning
def hgoe(_1)
end
```
```ruby
def _1; end
# expected: warning: `_1' is used as numbered parameter
# actual: no warning
x = _1
```
It would be good to write the reason why you expect so. But firstly I need to understand what you expect.
----------------------------------------
Feature #16293: Numbered parameter confirmation in Ruby 2.7
https://bugs.ruby-lang.org/issues/16293#change-82487
* Author: osyo (manga osyo)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error.
* No warning -> No error in the future
* Warning -> Deprecated syntax
* Error -> Error in Ruby 2.7
## Ruby version
```ruby
p RUBY_VERSION
# => "2.7.0"
p RUBY_DESCRIPTION
# => "ruby 2.7.0dev (2019-11-02T06:32:49Z trunk 772b0613c5) [x86_64-linux]"
p RUBY_RELEASE_DATE
# => "2019-11-02"
p RUBY_REVISION
# => "772b0613c583773cd2eda23bce8275926a351e79"
```
## [Log in DevelopersMeeting20190829Japan](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit)
* local variables (parameters and assigned variable) → force warning (Don’t use) on Ruby 2.7 and syntax error on Ruby 3.
* method invocation
* vcall: `x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3.
* vcall: `1.times{ _0 }` → block parameter (incompatibility)
* vcall: `1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3.
* method invocation (`x = _0(), x = foo._0`) → no warning
* method name (`def _0(); end`) → no warning
## Current behavior
```ruby
# No warning
# Defined parameter name `_1`
def hgoe(_1)
end
```
```ruby
def _1
:method
end
# No warning
# Call to method `_1`
x = _1
p x
# => :method
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
```ruby
def _1
:method
end
# Error: ordinary parameter is defined
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# No warning
# Defined local variable
_1 = 42
}
```
```ruby
def _1
:method
end
# No warning
p _1
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
## Proposal
* When deprecated in the future, it is necessary to issue a Warning
* Considering compatibility, make it Warning instead of Error
```ruby
def _1
:method
end
# Warning
# "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" in logs
x = _1
p x
# => :method
# Warning
p eval("_1")
```
```ruby
def _1
:method
end
# Warning
# "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." in logs
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# Warning
_1 = 42
}
```
```ruby
# Warning
# Since local variables are also warnings, formal parameters are also warnings
def hgoe(_1)
end
# NOTE
# `eval("_1")` refers to a dummy argument
def hoge(_1)
p proc {
_1
eval("_1")
}.call 42
end
hoge :argument
# => :argument
```
## Other behavior
* Is there any other syntax to change `No warning` `Warning` `Error` ?
### Example 1. Defined local variable name `_1`
```ruby
# Example 1-1
# Warning : defined local variable
_1 = 42
```
```ruby
# Example 1-2
# No warning : defined method name
def _1
42
end
```
```ruby
# Example 1-3
# No warning : defined parameter name
def hgoe(_1)
end
```
```ruby
# Example 1-4
# In block
proc {
# Warning: `_1' is used as Numbered parameter
_1 = 42
}
# Example 1-5
# In block and used Numbered parameter
proc {
_1
# No warning
_1 = 42
}
```
### Example 2. Refer to local variable `_1` in block
```ruby
_1 = :local_variable
# Example 2-1
# No warning
x = _1
p x
# => :local_variable
# Example 2-2
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 2-3
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 2-4
p proc {
_1
proc {
# No warning
_1
}.call
}.call 42
# => :local_variable
```
### Example 3. Refer to method `_1` in block
```ruby
def _1(a = nil)
:"method#{a}"
end
# Example 3-1
# No warning
x = _1
p x
# => :method
# Example 3-2
# No warning
x = _1 42
p x
# => :method42
# Example 3-3
# No warning
x = _1()
p x
# => :method
# Example 3-4
# Error
p proc { |i| _1 }.call 42
# Example 3-5
# No warning
p proc { |i| _1() }.call 42
# => :method
# Example 3-6
# No warning
p proc { |i| _1 i }.call 42
# => :method42
# Example 3-7
# No warning
p proc { |i| self._1 }.call 42
# => :method
# Example 3-8
# No warning
p proc { _1 }.call 42
# => 42
# Example 3-9
# No warning
p proc { _1 _2 }.call 42, 3
# => method3
# Example 3-10
# No warning
p proc { _1() }.call 42
# => :method
# Example 3-11
# No warning
p proc { self._1 }.call 42
# => :method
```
### Example 4. Defined local variable `_1` and method `_1`
```ruby
def _1(a = nil)
:"method#{a}"
end
_1 = :local_variable
# Example 4-1
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 4-2
# No warning
p proc { |i| _1() }.call 3
# => :method
# Example 4-3
# No warning
p proc { |i| _1 42 }.call 3
# => :method42
# Example 4-4
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 4-5
# No warning
p proc { _1() }.call 3
# => :method
# Example 4-6
# No warning
p proc { _1 42 }.call 3
# => :method42
```
### Example 5. Used `eval("_1")`
* `eval ("_1")` refers to local variables in preference
* The same goes for `binding.local_variable_get(:_1)`
* If local variable `_1` becomes Error, solve it?
* `eval("@1")` is Syntax Error
```ruby
# Example 5-1
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
```
```ruby
# Example 5-2
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
```ruby
_1 = :local_variable
# Example 5-3
# No warning
p eval("_1")
# => :local_variable
# Example 5-4
# No warning
p proc { eval("_1") }.call 42
# => :local_variable
# Example 5-5
# No warning
p proc { _1; eval("_1") }.call 42
# => :local_variable
```
```ruby
# Example 5-6
p proc {
_1
# Error: numbered parameter is already used in
# outer block here
proc { _1 }.call 3
}.call 42
```
```ruby
# Example 5-7
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => 42
```
```ruby
# Example 5-8
_1 = :local_variable
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => :local_variable
```
```ruby
def _1
:method
end
# Example 5-9
# No warning
p _1
# => :method
# Example 5-10
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
# Example 5-11
# No warning
p eval("_1()")
# => :method
# Example 5-12
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
# Example 5-13
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
### Example 6. Used default arguments
```ruby
# Example 6-1
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-2
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# OK
def _1
:method
end
p proc {
_1
eval("_1")
}.call 42
# => 42
```
```ruby
# Example 6-3
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
```ruby
# Example 6-4
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-5
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# Example 6-6
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
### Example 7. Refrer to `_1` in binding.irb
```ruby
# Example 7-1
proc {
_1
# Referencing _1 returns 42
binding.irb
}.call 42
```
```ruby
# Example 7-2
_1 = :local_variable
proc {
_1
# Referencing _1 returns :local_variable
binding.irb
}.call 42
```
Are there other edge cases for Numbered parameter?
Thank you :)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread* [ruby-core:95703] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7
[not found] <redmine.issue-16293.20191105121436@ruby-lang.org>
` (2 preceding siblings ...)
2019-11-05 13:05 ` [ruby-core:95700] " mame
@ 2019-11-05 16:18 ` shevegen
2019-11-06 0:58 ` [ruby-core:95716] " manga.osyo
2019-11-06 3:45 ` [ruby-core:95718] [Ruby master Bug#16293] " nobu
5 siblings, 0 replies; 6+ messages in thread
From: shevegen @ 2019-11-05 16:18 UTC (permalink / raw)
To: ruby-core
Issue #16293 has been updated by shevegen (Robert A. Heiler).
The present behaviour:
def _1; end
seems correct and osyo's example of expecting a warning instead seems incorrect to me, unless
he meant it in in some other context. (It is indeed difficult to break the suggestion down
since it is so long.)
----------------------------------------
Feature #16293: Numbered parameter confirmation in Ruby 2.7
https://bugs.ruby-lang.org/issues/16293#change-82489
* Author: osyo (manga osyo)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error.
* No warning -> No error in the future
* Warning -> Deprecated syntax
* Error -> Error in Ruby 2.7
## Ruby version
```ruby
p RUBY_VERSION
# => "2.7.0"
p RUBY_DESCRIPTION
# => "ruby 2.7.0dev (2019-11-02T06:32:49Z trunk 772b0613c5) [x86_64-linux]"
p RUBY_RELEASE_DATE
# => "2019-11-02"
p RUBY_REVISION
# => "772b0613c583773cd2eda23bce8275926a351e79"
```
## [Log in DevelopersMeeting20190829Japan](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit)
* local variables (parameters and assigned variable) → force warning (Don’t use) on Ruby 2.7 and syntax error on Ruby 3.
* method invocation
* vcall: `x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3.
* vcall: `1.times{ _0 }` → block parameter (incompatibility)
* vcall: `1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3.
* method invocation (`x = _0(), x = foo._0`) → no warning
* method name (`def _0(); end`) → no warning
## Current behavior
```ruby
# No warning
# Defined parameter name `_1`
def hgoe(_1)
end
```
```ruby
def _1
:method
end
# No warning
# Call to method `_1`
x = _1
p x
# => :method
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
```ruby
def _1
:method
end
# Error: ordinary parameter is defined
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# No warning
# Defined local variable
_1 = 42
}
```
```ruby
def _1
:method
end
# No warning
p _1
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
```
## Proposal
* When deprecated in the future, it is necessary to issue a Warning
* Considering compatibility, make it Warning instead of Error
```ruby
def _1
:method
end
# Warning
# "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" in logs
x = _1
p x
# => :method
# Warning
p eval("_1")
```
```ruby
def _1
:method
end
# Warning
# "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." in logs
p proc { |i| _1 }.call 42
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# Warning
_1 = 42
}
```
```ruby
# Warning
# Since local variables are also warnings, formal parameters are also warnings
def hgoe(_1)
end
# NOTE
# `eval("_1")` refers to a dummy argument
def hoge(_1)
p proc {
_1
eval("_1")
}.call 42
end
hoge :argument
# => :argument
```
## Other behavior
* Is there any other syntax to change `No warning` `Warning` `Error` ?
### Example 1. Defined local variable name `_1`
```ruby
# Example 1-1
# Warning : defined local variable
_1 = 42
```
```ruby
# Example 1-2
# No warning : defined method name
def _1
42
end
```
```ruby
# Example 1-3
# No warning : defined parameter name
def hgoe(_1)
end
```
```ruby
# Example 1-4
# In block
proc {
# Warning: `_1' is used as Numbered parameter
_1 = 42
}
# Example 1-5
# In block and used Numbered parameter
proc {
_1
# No warning
_1 = 42
}
```
### Example 2. Refer to local variable `_1` in block
```ruby
_1 = :local_variable
# Example 2-1
# No warning
x = _1
p x
# => :local_variable
# Example 2-2
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 2-3
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 2-4
p proc {
_1
proc {
# No warning
_1
}.call
}.call 42
# => :local_variable
```
### Example 3. Refer to method `_1` in block
```ruby
def _1(a = nil)
:"method#{a}"
end
# Example 3-1
# No warning
x = _1
p x
# => :method
# Example 3-2
# No warning
x = _1 42
p x
# => :method42
# Example 3-3
# No warning
x = _1()
p x
# => :method
# Example 3-4
# Error
p proc { |i| _1 }.call 42
# Example 3-5
# No warning
p proc { |i| _1() }.call 42
# => :method
# Example 3-6
# No warning
p proc { |i| _1 i }.call 42
# => :method42
# Example 3-7
# No warning
p proc { |i| self._1 }.call 42
# => :method
# Example 3-8
# No warning
p proc { _1 }.call 42
# => 42
# Example 3-9
# No warning
p proc { _1 _2 }.call 42, 3
# => method3
# Example 3-10
# No warning
p proc { _1() }.call 42
# => :method
# Example 3-11
# No warning
p proc { self._1 }.call 42
# => :method
```
### Example 4. Defined local variable `_1` and method `_1`
```ruby
def _1(a = nil)
:"method#{a}"
end
_1 = :local_variable
# Example 4-1
# No warning
p proc { |i| _1 }.call 3
# => :local_variable
# Example 4-2
# No warning
p proc { |i| _1() }.call 3
# => :method
# Example 4-3
# No warning
p proc { |i| _1 42 }.call 3
# => :method42
# Example 4-4
# No warning
p proc { _1 }.call 3
# => :local_variable
# Example 4-5
# No warning
p proc { _1() }.call 3
# => :method
# Example 4-6
# No warning
p proc { _1 42 }.call 3
# => :method42
```
### Example 5. Used `eval("_1")`
* `eval ("_1")` refers to local variables in preference
* The same goes for `binding.local_variable_get(:_1)`
* If local variable `_1` becomes Error, solve it?
* `eval("@1")` is Syntax Error
```ruby
# Example 5-1
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
```
```ruby
# Example 5-2
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
```ruby
_1 = :local_variable
# Example 5-3
# No warning
p eval("_1")
# => :local_variable
# Example 5-4
# No warning
p proc { eval("_1") }.call 42
# => :local_variable
# Example 5-5
# No warning
p proc { _1; eval("_1") }.call 42
# => :local_variable
```
```ruby
# Example 5-6
p proc {
_1
# Error: numbered parameter is already used in
# outer block here
proc { _1 }.call 3
}.call 42
```
```ruby
# Example 5-7
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => 42
```
```ruby
# Example 5-8
_1 = :local_variable
p proc {
_1
proc {
# No warning
eval("_1")
}.call 3
}.call 42
# => :local_variable
```
```ruby
def _1
:method
end
# Example 5-9
# No warning
p _1
# => :method
# Example 5-10
# Error: numbered parameter outside block (SyntaxError)
p eval("_1")
# Example 5-11
# No warning
p eval("_1()")
# => :method
# Example 5-12
# Error: numbered parameter outside block (SyntaxError)
p proc { eval("_1") }.call 42
# Example 5-13
# No warning
p proc { _1; eval("_1") }.call 42
# => 42
```
### Example 6. Used default arguments
```ruby
# Example 6-1
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-2
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# OK
def _1
:method
end
p proc {
_1
eval("_1")
}.call 42
# => 42
```
```ruby
# Example 6-3
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
```ruby
# Example 6-4
# OK
p proc { |_1|
-> (a = _1) { a }.call
}.call 42
# => 42
```
```ruby
# Example 6-5
# OK
_1 = :local_variable
p proc {
-> (a = _1) { a }.call
}.call 42
# => :local_variable
```
```ruby
# Example 6-6
# NG
p proc {
# Error: ordinary parameter is defined
-> (a = _1) { a }.call
}.call 42
```
### Example 7. Refrer to `_1` in binding.irb
```ruby
# Example 7-1
proc {
_1
# Referencing _1 returns 42
binding.irb
}.call 42
```
```ruby
# Example 7-2
_1 = :local_variable
proc {
_1
# Referencing _1 returns :local_variable
binding.irb
}.call 42
```
Are there other edge cases for Numbered parameter?
Thank you :)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread* [ruby-core:95716] [Ruby master Feature#16293] Numbered parameter confirmation in Ruby 2.7
[not found] <redmine.issue-16293.20191105121436@ruby-lang.org>
` (3 preceding siblings ...)
2019-11-05 16:18 ` [ruby-core:95703] " shevegen
@ 2019-11-06 0:58 ` manga.osyo
2019-11-06 3:45 ` [ruby-core:95718] [Ruby master Bug#16293] " nobu
5 siblings, 0 replies; 6+ messages in thread
From: manga.osyo @ 2019-11-06 0:58 UTC (permalink / raw)
To: ruby-core
Issue #16293 has been updated by osyo (manga osyo).
Thank you all.
I updated text.
----------------------------------------
Feature #16293: Numbered parameter confirmation in Ruby 2.7
https://bugs.ruby-lang.org/issues/16293#change-82503
* Author: osyo (manga osyo)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error).
There is a difference in [DevelopersMeeting20190829Japan logs](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit) and behavior.
## Ruby version
```ruby
p RUBY_VERSION
# => "2.7.0"
p RUBY_DESCRIPTION
# => "ruby 2.7.0dev (2019-11-02T06:32:49Z trunk 772b0613c5) [x86_64-linux]"
p RUBY_RELEASE_DATE
# => "2019-11-02"
p RUBY_REVISION
# => "772b0613c583773cd2eda23bce8275926a351e79"
```
## [DevelopersMeeting20190829Japan logs](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit)
* local variables (parameters and assigned variable) → force warning (Don’t use) on Ruby 2.7 and syntax error on Ruby 3.
* method invocation
* vcall: `x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3.
* vcall: `1.times{ _0 }` → block parameter (incompatibility)
* vcall: `1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3.
* method invocation (`x = _0(), x = foo._0`) → no warning
* method name (`def _0(); end`) → no warning
## Proposal
```ruby
def _1; end
# expected: warning: `_1' is used as numbered parameter
# actual: No warning
# reason: Because "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" is written in the log
x = _1
# expected: warning: `_1' is used as numbered parameter
# and call to _1()
# actual: Error: numbered parameter outside block (SyntaxError)
# reason: Because hoge() method is called with `eval("hoge")`
eval("_1")
```
```ruby
def _1; end
# expected: warning: `_1' is used as numbered parameter
# and call to _1()
# actual: Error: ordinary parameter is defined
# reason: Because "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." is written in the log
proc { |i| _1 }.call 42
```
```ruby
# expected: warning: `_1' is used as numbered parameter
# actual: No warning
# reason: Because define local variable _1 is warning
def hgoe(_1)
end
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# expected: warning: `_1' is used as numbered parameter
# actual: No warning
# reason: Because define local variable _1 is warning
_1 = 42
}
```
## :MEMO: Other behavior
* Other current behavior : https://gist.github.com/osyo-manga/f332ba1f31dbc3a437acd4d86d7986dc
* Is there any other syntax to change `No warning` `Warning` `Error` ?
* Considering compatibility, make it Warning instead of Error ?
Are there other edge cases for Numbered parameter?
Thank you :)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread* [ruby-core:95718] [Ruby master Bug#16293] Numbered parameter confirmation in Ruby 2.7
[not found] <redmine.issue-16293.20191105121436@ruby-lang.org>
` (4 preceding siblings ...)
2019-11-06 0:58 ` [ruby-core:95716] " manga.osyo
@ 2019-11-06 3:45 ` nobu
5 siblings, 0 replies; 6+ messages in thread
From: nobu @ 2019-11-06 3:45 UTC (permalink / raw)
To: ruby-core
Issue #16293 has been updated by nobu (Nobuyoshi Nakada).
Backport set to 2.5: UNKNOWN, 2.6: UNKNOWN
Tracker changed from Feature to Bug
> ```ruby
> def _1; end
>
> # expected: warning: `_1' is used as numbered parameter
> # actual: No warning
> # reason: Because "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" is written in the log
> x = _1
The "outside block" warning is shown at assignment to a local variable looks like a numbered parameter.
There is no assignment.
> ```ruby
> # expected: warning: `_1' is used as numbered parameter
> # and call to _1()
> # actual: Error: numbered parameter outside block (SyntaxError)
> # reason: Because hoge() method is called with `eval("hoge")`
> eval("_1")
> ```
This is a bug.
As numbered parameter looks like an ordinary variable now, the warning doesn't make sense.
> ```ruby
> def _1; end
>
> # expected: warning: `_1' is used as numbered parameter
> # and call to _1()
> # actual: Error: ordinary parameter is defined
> # reason: Because "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." is written in the log
> proc { |i| _1 }.call 42
> ```
The method is irrelevant, Ruby doesn't know if it is defined or not until calling it.
And `_1` in a block is considered as a numbered parameter, it conflicts with `|i|`.
> ```ruby
> # expected: warning: `_1' is used as numbered parameter
> # actual: No warning
> # reason: Because define local variable _1 is warning
> def hgoe(_1)
> end
> ```
It is outside block.
> ```ruby
> proc {
> # Warning
> _1 = 42
> }
>
> proc {
> _1
> # expected: warning: `_1' is used as numbered parameter
> # actual: No warning
> # reason: Because define local variable _1 is warning
> _1 = 42
> }
> ```
This is a bug.
It must be a syntax error.
It was a syntax error in old versions actually.
----------------------------------------
Bug #16293: Numbered parameter confirmation in Ruby 2.7
https://bugs.ruby-lang.org/issues/16293#change-82505
* Author: osyo (manga osyo)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
## Overview
I want to make a final check on the behavior of Numbered parameter( No warning or Warning or Error).
There is a difference in [DevelopersMeeting20190829Japan logs](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit) and behavior.
## Ruby version
```ruby
p RUBY_VERSION
# => "2.7.0"
p RUBY_DESCRIPTION
# => "ruby 2.7.0dev (2019-11-02T06:32:49Z trunk 772b0613c5) [x86_64-linux]"
p RUBY_RELEASE_DATE
# => "2019-11-02"
p RUBY_REVISION
# => "772b0613c583773cd2eda23bce8275926a351e79"
```
## [DevelopersMeeting20190829Japan logs](https://docs.google.com/document/d/1XypDO1crRV9uNg1_ajxkljVdN8Vdyl5hnz462bDQw34/edit)
* local variables (parameters and assigned variable) → force warning (Don’t use) on Ruby 2.7 and syntax error on Ruby 3.
* method invocation
* vcall: `x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3.
* vcall: `1.times{ _0 }` → block parameter (incompatibility)
* vcall: `1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3.
* method invocation (`x = _0(), x = foo._0`) → no warning
* method name (`def _0(); end`) → no warning
## Proposal
```ruby
def _1; end
# expected: warning: `_1' is used as numbered parameter
# actual: No warning
# reason: Because "`x = _0 # expect _0()` outside block. → force warning on Ruby 2.7 and syntax error on Ruby 3" is written in the log
x = _1
# expected: warning: `_1' is used as numbered parameter
# and call to _1()
# actual: Error: numbered parameter outside block (SyntaxError)
# reason: Because hoge() method is called with `eval("hoge")`
eval("_1")
```
```ruby
def _1; end
# expected: warning: `_1' is used as numbered parameter
# and call to _1()
# actual: Error: ordinary parameter is defined
# reason: Because "`1.times{|i| _0 }` → force warning on Ruby 2.7 and syntax error on Ruby 3." is written in the log
proc { |i| _1 }.call 42
```
```ruby
# expected: warning: `_1' is used as numbered parameter
# actual: No warning
# reason: Because define local variable _1 is warning
def hgoe(_1)
end
```
```ruby
proc {
# Warning
_1 = 42
}
proc {
_1
# expected: warning: `_1' is used as numbered parameter
# actual: No warning
# reason: Because define local variable _1 is warning
_1 = 42
}
```
## :MEMO: Other behavior
* Other current behavior : https://gist.github.com/osyo-manga/f332ba1f31dbc3a437acd4d86d7986dc
* Is there any other syntax to change `No warning` `Warning` `Error` ?
* Considering compatibility, make it Warning instead of Error ?
Are there other edge cases for Numbered parameter?
Thank you :)
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 6+ messages in thread