From: stevendaniels88@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95284] [Ruby master Feature#16244] Add a Time#before? and Time#after? method
Date: Tue, 08 Oct 2019 23:26:58 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-81964.20191008232658.2bc3b537bacbd7b1@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16244.20191007164739@ruby-lang.org
Issue #16244 has been updated by stevendaniels (Steven Daniels).
sawa (Tsuyoshi Sawada) wrote:
>You should not be writing like that. You should either do somthing like
>
> ```
> birthday + thirteen_years > now
> ```
>
> or
>
> ```
> now - birthday < thirteen_years
> ```
In your example, your coercing the dates to Floats and then comparing integers. Part of the reason I think `before?`/`after?` would be a good addition is because they remove the need to coerce a `Time` in order to do a comparison. I think your solution illustrates part of the problem
I agree that my example in the beginning isn't perfect. A better example might be this:
```ruby
steven.birthday.before? john.birthday
```
instead of
```ruby
steven.birthday < john.birthday
```
I have a more basic question: are there specific criteria for accepting alias methods for core objects? Is Ruby's preference to avoid adding alias methods?
----------------------------------------
Feature #16244: Add a Time#before? and Time#after? method
https://bugs.ruby-lang.org/issues/16244#change-81964
* Author: stevendaniels (Steven Daniels)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
Comparing times using `>` and`<` can be pretty confusing.
I'd like to propose `Time#before?` and `Time#after?` methods for aliasing `Time#<` and `Time#>`
These method aliases would make the code more readable. :)
Current syntax:
``` ruby
if current_time < expiration_at
# do stuff
end
if birthday > thirteen_years_ago
# you need a parent's permission to sign up
end
```
What I'd like to see added:
``` ruby
if current_time.before? expiration_at
# do stuff
end
if birthday.after? thirteen_years_ago
# you need a parent's permission to sign up
end
```
Thanks for your consideration!
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2019-10-08 23:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-16244.20191007164739@ruby-lang.org>
2019-10-07 16:47 ` [ruby-core:95260] [Ruby master Feature#16244] Add a Time#before? and Time#after? method stevendaniels88
2019-10-07 17:07 ` [ruby-core:95261] " merch-redmine
2019-10-07 19:43 ` [ruby-core:95263] " stevendaniels88
2019-10-07 23:34 ` [ruby-core:95273] " sawadatsuyoshi
2019-10-08 23:26 ` stevendaniels88 [this message]
2019-10-09 6:52 ` [ruby-core:95287] " keithrbennett
2019-12-13 18:30 ` [ruby-core:96221] " anastasia.k.stowers
2019-12-15 0:59 ` [ruby-core:96241] " nobu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-81964.20191008232658.2bc3b537bacbd7b1@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).