From: stevendaniels88@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:95263] [Ruby master Feature#16244] Add a Time#before? and Time#after? method
Date: Mon, 07 Oct 2019 19:43:39 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-81940.20191007194338.0dc548df3c4d0713@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16244.20191007164739@ruby-lang.org
Issue #16244 has been updated by stevendaniels (Steven Daniels).
jeremyevans0 (Jeremy Evans) wrote:
> I would guess the `>` and `<` symbols are probably more understandable to people whose native language is not English, at least.
It's hard to speak for all non-native English speakers one way or the other, but in the languages non-English languages I speak, using **greater than** and **less than** to compare times isn't a natural way to frame the comparison; by comparison, before and after is a natural way to compare times in most languages.
Over the years I've seen this confusion manifested by developers of all levels of experience leading to real life bugs. Adding aliases that help to alleviate that confusion would be a nice thing to provide to all Ruby developers (which is why I'm making this feature request).
Subjectively speaking, comparisons like`if blog.published_at.before? Time.now` feel more natural than `if blog.published_at < Time.now`.
(Big fan of your work, BTW!)
----------------------------------------
Feature #16244: Add a Time#before? and Time#after? method
https://bugs.ruby-lang.org/issues/16244#change-81940
* Author: stevendaniels (Steven Daniels)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
Comparing times using `>` and`<` can be pretty confusing.
I'd like to propose `Time#before?` and `Time#after?` methods for aliasing `Time#<` and `Time#>`
These method aliases would make the code more readable. :)
Current syntax:
``` ruby
if current_time < expiration_at
# do stuff
end
if birthday > thirteen_years_ago
# you need a parent's permission to sign up
end
```
What I'd like to see added:
``` ruby
if current_time.before? expiration_at
# do stuff
end
if birthday.after? thirteen_years_ago
# you need a parent's permission to sign up
end
```
Thanks for your consideration!
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2019-10-07 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-16244.20191007164739@ruby-lang.org>
2019-10-07 16:47 ` [ruby-core:95260] [Ruby master Feature#16244] Add a Time#before? and Time#after? method stevendaniels88
2019-10-07 17:07 ` [ruby-core:95261] " merch-redmine
2019-10-07 19:43 ` stevendaniels88 [this message]
2019-10-07 23:34 ` [ruby-core:95273] " sawadatsuyoshi
2019-10-08 23:26 ` [ruby-core:95284] " stevendaniels88
2019-10-09 6:52 ` [ruby-core:95287] " keithrbennett
2019-12-13 18:30 ` [ruby-core:96221] " anastasia.k.stowers
2019-12-15 0:59 ` [ruby-core:96241] " nobu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-81940.20191007194338.0dc548df3c4d0713@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).