From: mame@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92677] [Ruby trunk Bug#15853] Fix readline test regression when using Readline 4.3
Date: Thu, 16 May 2019 04:39:27 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-78039.20190516043926.ed703292599f46f9@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15853.20190516042021@ruby-lang.org
Issue #15853 has been updated by mame (Yusuke Endoh).
```
- if !defined?(Reline) or Readline != Reline # Reline's rendering logic is tricky
+ unless defined?(Reline) or Readline == Reline or /\A4\.3\z/n.match(Readline::VERSION) # Reline's rendering logic is tricky
```
The new condition looks not to work when `Reline` is not defined.
(Personally I want to avoid `unless` for complex condition :-)
----------------------------------------
Bug #15853: Fix readline test regression when using Readline 4.3
https://bugs.ruby-lang.org/issues/15853#change-78039
* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Assignee: aycabta (aycabta .)
* Target version:
* ruby -v:
* Backport: 2.4: DONTNEED, 2.5: DONTNEED, 2.6: DONTNEED
----------------------------------------
commit:c754e979d3eeca51f1b13778f19f347df3da656e removed the check for Readline 4.3 in a test. Previously, the whole test was skipped on Readline 4.3. However, it turns out that Readline 4.3 runs the test correctly if you skip the same assertion that is skipped when Reline is used. The attached patch skips that assertion when `Readline::VERSION` is 4.3.
We may want to consider dropping this assertion completely, it seems to be readline implementation and version dependent behavior.
---Files--------------------------------
fix-readline-4.3-test-regression.patch (1.3 KB)
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2019-05-16 4:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15853.20190516042021@ruby-lang.org>
2019-05-16 4:20 ` [ruby-core:92676] [Ruby trunk Bug#15853] Fix readline test regression when using Readline 4.3 merch-redmine
2019-05-16 4:39 ` mame [this message]
2019-05-16 4:57 ` [ruby-core:92678] " merch-redmine
2019-05-17 9:39 ` [ruby-core:92693] " aycabta
2019-05-17 15:00 ` [ruby-core:92699] " merch-redmine
2019-05-17 15:23 ` [ruby-core:92700] " mame
2019-05-17 16:23 ` [ruby-core:92702] " merch-redmine
2019-05-22 5:09 ` [ruby-core:92758] " matz
2019-05-22 14:20 ` [ruby-core:92785] " mame
2019-05-22 14:34 ` [ruby-core:92786] " aycabta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-78039.20190516043926.ed703292599f46f9@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).