From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 5E1151F461 for ; Thu, 16 May 2019 04:39:36 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EFD8D120A7D; Thu, 16 May 2019 13:39:29 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 4DAD2120922 for ; Thu, 16 May 2019 13:39:26 +0900 (JST) Received: by filter0130p3las1.sendgrid.net with SMTP id filter0130p3las1-8453-5CDCE97F-7 2019-05-16 04:39:27.19645284 +0000 UTC m=+21623.672880637 Received: from herokuapp.com (unknown [34.228.185.226]) by ismtpd0068p1mdw1.sendgrid.net (SG) with ESMTP id LMiGO5eCR7-hpP8_J0UXAQ for ; Thu, 16 May 2019 04:39:26.906 +0000 (UTC) Date: Thu, 16 May 2019 04:39:27 +0000 (UTC) From: mame@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 68160 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15853 X-Redmine-Issue-Author: jeremyevans0 X-Redmine-Issue-Assignee: aycabta X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EJh2gqwnyqXtd++xo=2FinyA1V0bXouTB4FkWnzNiKb491cy2eWovDYw0TkkqgW4?= =?us-ascii?Q?zRxCnHOXHP1dDKTvW=2FOQCqVhtW+iBwZEdEUEvrq?= =?us-ascii?Q?6FW+4Gj6mgzKvlMOHzog1ooXvDMFJtP69=2FsZaLm?= =?us-ascii?Q?5jJIKdEO=2FYHQ35Y9kKk51VTvvgDRJqlb=2FFxTFyG?= =?us-ascii?Q?Dlbl3F+IElHMxFwZzfg5B0cNFMLqXRPBd2g=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92677 Subject: [ruby-core:92677] [Ruby trunk Bug#15853] Fix readline test regression when using Readline 4.3 X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15853 has been updated by mame (Yusuke Endoh). ``` - if !defined?(Reline) or Readline != Reline # Reline's rendering logic is tricky + unless defined?(Reline) or Readline == Reline or /\A4\.3\z/n.match(Readline::VERSION) # Reline's rendering logic is tricky ``` The new condition looks not to work when `Reline` is not defined. (Personally I want to avoid `unless` for complex condition :-) ---------------------------------------- Bug #15853: Fix readline test regression when using Readline 4.3 https://bugs.ruby-lang.org/issues/15853#change-78039 * Author: jeremyevans0 (Jeremy Evans) * Status: Open * Priority: Normal * Assignee: aycabta (aycabta .) * Target version: * ruby -v: * Backport: 2.4: DONTNEED, 2.5: DONTNEED, 2.6: DONTNEED ---------------------------------------- commit:c754e979d3eeca51f1b13778f19f347df3da656e removed the check for Readline 4.3 in a test. Previously, the whole test was skipped on Readline 4.3. However, it turns out that Readline 4.3 runs the test correctly if you skip the same assertion that is skipped when Reline is used. The attached patch skips that assertion when `Readline::VERSION` is 4.3. We may want to consider dropping this assertion completely, it seems to be readline implementation and version dependent behavior. ---Files-------------------------------- fix-readline-4.3-test-regression.patch (1.3 KB) -- https://bugs.ruby-lang.org/