From: mame@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:92450] [Ruby trunk Bug#12812] Added Coverage#result=
Date: Sat, 27 Apr 2019 22:27:09 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-77801.20190427222708.250fcf53bbce4b55@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-12812.20161006002448@ruby-lang.org
Issue #12812 has been updated by mame (Yusuke Endoh).
Status changed from Feedback to Rejected
I'd like to close this issue tentatively. Feel free to reopen if you still think it is needed.
----------------------------------------
Bug #12812: Added Coverage#result=
https://bugs.ruby-lang.org/issues/12812#change-77801
* Author: zenspider (Ryan Davis)
* Status: Rejected
* Priority: Normal
* Assignee: mame (Yusuke Endoh)
* Target version:
* ruby -v:
* Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
----------------------------------------
Originally submitted here: https://github.com/ruby/ruby/pull/1456
This exposes Coverage.result in a slightly more writeable way and allows coverage analysis to reset to a baseline in a safe way.
Note, I wasn't able to figure out how to invalidate the cached pointers in the VM bytecode, so this does `rb_ary_replace` across all the arrays instead. I'd love to see this improved so it were cleaner.
This is ongoing work to improve the current state of code coverage analysis. I'll be giving a talk on this at rubyconf 2016.
I should also add, this applies cleanly to (at least) 2.3 as well.
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2019-04-27 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-12812.20161006002448@ruby-lang.org>
2016-10-06 0:24 ` [ruby-core:77493] [Ruby trunk Bug#12812] Added Coverage#result= ryand-ruby
2016-10-06 0:32 ` [ruby-core:77494] [Ruby trunk Bug#12812][Assigned] " hsbt
2016-10-06 3:30 ` [ruby-core:77496] [Ruby trunk Bug#12812] " ryand-ruby
2019-01-21 8:37 ` [ruby-core:91206] " mame
2019-04-27 22:27 ` mame [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-77801.20190427222708.250fcf53bbce4b55@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).