From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 804BF1F453 for ; Sat, 27 Apr 2019 22:27:13 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 28DFF1209F5; Sun, 28 Apr 2019 07:27:09 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id C0E6512095E for ; Sun, 28 Apr 2019 07:27:07 +0900 (JST) Received: by filter0182p3mdw1.sendgrid.net with SMTP id filter0182p3mdw1-2622-5CC4D73D-A 2019-04-27 22:27:09.16013725 +0000 UTC m=+177898.166404435 Received: from herokuapp.com (unknown [3.88.222.166]) by ismtpd0018p1iad2.sendgrid.net (SG) with ESMTP id VJSUC2F3QkuTvU6wVEGHCQ for ; Sat, 27 Apr 2019 22:27:09.158 +0000 (UTC) Date: Sat, 27 Apr 2019 22:27:09 +0000 (UTC) From: mame@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 67933 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 12812 X-Redmine-Issue-Author: zenspider X-Redmine-Issue-Assignee: mame X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?EJh2gqwnyqXtd++xo=2FinyA1V0bXouTB4FkWnzNiKb48pZJ1Ghf5ZIoKn=2F0EMP9?= =?us-ascii?Q?Jxq2FgZ8OOB8C+N223YEubgwLVF00S0a4Hn38hs?= =?us-ascii?Q?FG=2FywYM2CxOiRoS0vxKssaQ4rbt79qqZZqu48Cb?= =?us-ascii?Q?Sz0Kuf4+79p9TDKahPk77oiZleKZBRYmoMKkJVY?= =?us-ascii?Q?FRgHoHO5kkdxHjWYqSAcWZdYRSpt94udQSw=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 92450 Subject: [ruby-core:92450] [Ruby trunk Bug#12812] Added Coverage#result= X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #12812 has been updated by mame (Yusuke Endoh). Status changed from Feedback to Rejected I'd like to close this issue tentatively. Feel free to reopen if you still think it is needed. ---------------------------------------- Bug #12812: Added Coverage#result= https://bugs.ruby-lang.org/issues/12812#change-77801 * Author: zenspider (Ryan Davis) * Status: Rejected * Priority: Normal * Assignee: mame (Yusuke Endoh) * Target version: * ruby -v: * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN ---------------------------------------- Originally submitted here: https://github.com/ruby/ruby/pull/1456 This exposes Coverage.result in a slightly more writeable way and allows coverage analysis to reset to a baseline in a safe way. Note, I wasn't able to figure out how to invalidate the cached pointers in the VM bytecode, so this does `rb_ary_replace` across all the arrays instead. I'd love to see this improved so it were cleaner. This is ongoing work to improve the current state of code coverage analysis. I'll be giving a talk on this at rubyconf 2016. I should also add, this applies cleanly to (at least) 2.3 as well. -- https://bugs.ruby-lang.org/