ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:91505] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined?
       [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
@ 2019-02-10 20:28 ` aaron.lasseigne
  2019-02-11  6:57 ` [ruby-core:91507] " nobu
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: aaron.lasseigne @ 2019-02-10 20:28 UTC (permalink / raw)
  To: ruby-core

Issue #15597 has been reported by AaronLasseigne (Aaron Lasseigne).

----------------------------------------
Bug #15597: syscall not returning true from private_method_defined?
https://bugs.ruby-lang.org/issues/15597

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
`syscode` is a private method on `Object` but when checked with `private_method_defined?` it returns `false`.

Ruby 2.6.1
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> [:syscall]
```

Ruby 2.5.3
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> []
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:91507] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined?
       [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
  2019-02-10 20:28 ` [ruby-core:91505] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined? aaron.lasseigne
@ 2019-02-11  6:57 ` nobu
  2019-02-13  4:44 ` [ruby-core:91527] " aaron.lasseigne
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: nobu @ 2019-02-11  6:57 UTC (permalink / raw)
  To: ruby-core

Issue #15597 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Open to Feedback

What is your OS?
Doesn't `syscall` method always raise a `NotImplementedError`?

----------------------------------------
Bug #15597: syscall not returning true from private_method_defined?
https://bugs.ruby-lang.org/issues/15597#change-76768

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Feedback
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
`syscode` is a private method on `Object` but when checked with `private_method_defined?` it returns `false`.

Ruby 2.6.1
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> [:syscall]
```

Ruby 2.5.3
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> []
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:91527] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined?
       [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
  2019-02-10 20:28 ` [ruby-core:91505] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined? aaron.lasseigne
  2019-02-11  6:57 ` [ruby-core:91507] " nobu
@ 2019-02-13  4:44 ` aaron.lasseigne
  2019-02-13 14:57 ` [ruby-core:91531] " hanmac
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: aaron.lasseigne @ 2019-02-13  4:44 UTC (permalink / raw)
  To: ruby-core

Issue #15597 has been updated by AaronLasseigne (Aaron Lasseigne).


I'm on MacOS 10.14.3 and yes it does raise a `NotImplementedError`. Even so, shouldn't it be shown as a private method?

----------------------------------------
Bug #15597: syscall not returning true from private_method_defined?
https://bugs.ruby-lang.org/issues/15597#change-76788

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Feedback
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
`syscode` is a private method on `Object` but when checked with `private_method_defined?` it returns `false`.

Ruby 2.6.1
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> [:syscall]
```

Ruby 2.5.3
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> []
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:91531] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined?
       [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
                   ` (2 preceding siblings ...)
  2019-02-13  4:44 ` [ruby-core:91527] " aaron.lasseigne
@ 2019-02-13 14:57 ` hanmac
  2019-02-14  4:13 ` [ruby-core:91541] " nobu
  2019-02-14 12:30 ` [ruby-core:91547] " hanmac
  5 siblings, 0 replies; 6+ messages in thread
From: hanmac @ 2019-02-13 14:57 UTC (permalink / raw)
  To: ruby-core

Issue #15597 has been updated by Hanmac (Hans Mackowiak).


@Nobu : this commit changed it

https://github.com/ruby/ruby/commit/67d87b192b23a75092280b534570580df0f8f7a5

specially this line:

```ruby
if (me->def->type == VM_METHOD_TYPE_NOTIMPLEMENTED) return METHOD_VISI_UNDEF;
```

means for each not implemented method, the visibility is undef, and the checks does fail

----------------------------------------
Bug #15597: syscall not returning true from private_method_defined?
https://bugs.ruby-lang.org/issues/15597#change-76790

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Feedback
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
`syscode` is a private method on `Object` but when checked with `private_method_defined?` it returns `false`.

Ruby 2.6.1
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> [:syscall]
```

Ruby 2.5.3
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> []
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:91541] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined?
       [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
                   ` (3 preceding siblings ...)
  2019-02-13 14:57 ` [ruby-core:91531] " hanmac
@ 2019-02-14  4:13 ` nobu
  2019-02-14 12:30 ` [ruby-core:91547] " hanmac
  5 siblings, 0 replies; 6+ messages in thread
From: nobu @ 2019-02-14  4:13 UTC (permalink / raw)
  To: ruby-core

Issue #15597 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Feedback to Rejected

It's same as that `respond_to?(:syscall, true)` returns `false`.

----------------------------------------
Bug #15597: syscall not returning true from private_method_defined?
https://bugs.ruby-lang.org/issues/15597#change-76804

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Rejected
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
`syscode` is a private method on `Object` but when checked with `private_method_defined?` it returns `false`.

Ruby 2.6.1
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> [:syscall]
```

Ruby 2.5.3
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> []
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:91547] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined?
       [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
                   ` (4 preceding siblings ...)
  2019-02-14  4:13 ` [ruby-core:91541] " nobu
@ 2019-02-14 12:30 ` hanmac
  5 siblings, 0 replies; 6+ messages in thread
From: hanmac @ 2019-02-14 12:30 UTC (permalink / raw)
  To: ruby-core

Issue #15597 has been updated by Hanmac (Hans Mackowiak).


@nobu should we change what the #methods returns? or is that to much work?

----------------------------------------
Bug #15597: syscall not returning true from private_method_defined?
https://bugs.ruby-lang.org/issues/15597#change-76810

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Rejected
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
`syscode` is a private method on `Object` but when checked with `private_method_defined?` it returns `false`.

Ruby 2.6.1
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> [:syscall]
```

Ruby 2.5.3
```
irb(main):001:0> Object.new.private_methods.sort.select { |pm| !Object.private_method_defined?(pm) }
=> []
```



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-02-14 12:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <redmine.issue-15597.20190210202856@ruby-lang.org>
2019-02-10 20:28 ` [ruby-core:91505] [Ruby trunk Bug#15597] syscall not returning true from private_method_defined? aaron.lasseigne
2019-02-11  6:57 ` [ruby-core:91507] " nobu
2019-02-13  4:44 ` [ruby-core:91527] " aaron.lasseigne
2019-02-13 14:57 ` [ruby-core:91531] " hanmac
2019-02-14  4:13 ` [ruby-core:91541] " nobu
2019-02-14 12:30 ` [ruby-core:91547] " hanmac

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).