ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output
       [not found] <redmine.issue-9577.20140228074416@ruby-lang.org>
@ 2014-02-28  7:44 ` normalperson
  2014-02-28 12:26   ` [ruby-core:61144] " SASADA Koichi
  2014-02-28 12:30 ` [ruby-core:61145] [ruby-trunk - Feature #9577] " ko1
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: normalperson @ 2014-02-28  7:44 UTC (permalink / raw)
  To: ruby-core

Issue #9577 has been reported by Eric Wong.

----------------------------------------
Feature #9577: [PATCH] benchmark/driver.rb: align columns in text output
https://bugs.ruby-lang.org/issues/9577

* Author: Eric Wong
* Status: Open
* Priority: Low
* Assignee: Eric Wong
* Category: misc
* Target version: current: 2.2.0
----------------------------------------
It is easier to read output when columns are aligned properly.
I have an 80 column terminal, that's HUGE!  Use it :D

pulL: git://80x24.org/ruby.git bmdriver-align
patch: http://bogomips.org/ruby.git/patch?id=32eed05c80

samples
before: http://80x24.org/bmlog-20140126-003136.7320.gz
after:  http://80x24.org/bmlog-20140228-071544.1805.gz

I'll commit soon unless this breaks some tools (or this makes life hard
for the 40-column people :P)




-- 
http://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:61144] Re: [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output
  2014-02-28  7:44 ` [ruby-core:61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output normalperson
@ 2014-02-28 12:26   ` SASADA Koichi
  2014-02-28 16:38     ` [ruby-core:61146] " Eric Wong
  0 siblings, 1 reply; 6+ messages in thread
From: SASADA Koichi @ 2014-02-28 12:26 UTC (permalink / raw)
  To: ruby-core

(2014/02/28 16:44), normalperson@yhbt.net wrote:
> It is easier to read output when columns are aligned properly.
> I have an 80 column terminal, that's HUGE!  Use it :D

Sorry, I can't read .gz file because of my environment.

What happen when many executables are specified (over 80 chars)?

-- 
// SASADA Koichi at atdot dot net

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:61145] [ruby-trunk - Feature #9577] [PATCH] benchmark/driver.rb: align columns in text output
       [not found] <redmine.issue-9577.20140228074416@ruby-lang.org>
  2014-02-28  7:44 ` [ruby-core:61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output normalperson
@ 2014-02-28 12:30 ` ko1
  2014-02-28 16:42 ` [ruby-core:61148] " normalperson
  2018-11-30 14:33 ` [ruby-core:90191] [Ruby trunk Feature#9577][Closed] " takashikkbn
  3 siblings, 0 replies; 6+ messages in thread
From: ko1 @ 2014-02-28 12:30 UTC (permalink / raw)
  To: ruby-core

Issue #9577 has been updated by Koichi Sasada.


 (2014/02/28 16:44), normalperson@yhbt.net wrote:
 > It is easier to read output when columns are aligned properly.
 > I have an 80 column terminal, that's HUGE!  Use it :D
 
 Sorry, I can't read .gz file because of my environment.
 
 What happen when many executables are specified (over 80 chars)?
 
 -- 
 // SASADA Koichi at atdot dot net

----------------------------------------
Feature #9577: [PATCH] benchmark/driver.rb: align columns in text output
https://bugs.ruby-lang.org/issues/9577#change-45520

* Author: Eric Wong
* Status: Open
* Priority: Low
* Assignee: Eric Wong
* Category: misc
* Target version: current: 2.2.0
----------------------------------------
It is easier to read output when columns are aligned properly.
I have an 80 column terminal, that's HUGE!  Use it :D

pulL: git://80x24.org/ruby.git bmdriver-align
patch: http://bogomips.org/ruby.git/patch?id=32eed05c80

samples
before: http://80x24.org/bmlog-20140126-003136.7320.gz
after:  http://80x24.org/bmlog-20140228-071544.1805.gz

I'll commit soon unless this breaks some tools (or this makes life hard
for the 40-column people :P)




-- 
http://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:61146] Re: [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output
  2014-02-28 12:26   ` [ruby-core:61144] " SASADA Koichi
@ 2014-02-28 16:38     ` Eric Wong
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Wong @ 2014-02-28 16:38 UTC (permalink / raw)
  To: Ruby developers

SASADA Koichi <ko1@atdot.net> wrote:
> (2014/02/28 16:44), normalperson@yhbt.net wrote:
> > It is easier to read output when columns are aligned properly.
> > I have an 80 column terminal, that's HUGE!  Use it :D
> 
> Sorry, I can't read .gz file because of my environment.

unzipped versions:
before: http://80x24.org/bmlog-20140126-003136.7320.txt
after:  http://80x24.org/bmlog-20140228-071544.1805.txt

> What happen when many executables are specified (over 80 chars)?

This the timing lines after the text source is just aligned to the
longest line, so it looks like this:

	ruby 2.2.0dev (2014-02-28 trunk 45211) [x86_64-linux]   0.071003417
	built-ruby                                              0.0817603

Execution time summary header isn't changed, but the times themselves
look much better:

	Execution time (sec)
	name	ruby 2.2.0dev (2014-02-28 trunk 45211) [x86_64-linux]	built-ruby
	app_answer                         0.071    0.082
	app_aobench                       84.672   84.014
	app_erb                            1.511    1.524

I didn't check the speedup ratio header, but maybe the "name\tbuilt-ruby"
looks a little odd.  I can fix that.  The first line
("compare with the result of") is unchanged (and too long, but I don't
read that).

	Speedup ratio: compare with the result of `ruby 2.2.0dev (2014-02-28 trunk 45211) [x86_64-linux]' (greater is better)
	name	built-ruby
	app_answer                         0.868
	app_aobench                        1.008
	app_erb                            0.992

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:61148] [ruby-trunk - Feature #9577] [PATCH] benchmark/driver.rb: align columns in text output
       [not found] <redmine.issue-9577.20140228074416@ruby-lang.org>
  2014-02-28  7:44 ` [ruby-core:61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output normalperson
  2014-02-28 12:30 ` [ruby-core:61145] [ruby-trunk - Feature #9577] " ko1
@ 2014-02-28 16:42 ` normalperson
  2018-11-30 14:33 ` [ruby-core:90191] [Ruby trunk Feature#9577][Closed] " takashikkbn
  3 siblings, 0 replies; 6+ messages in thread
From: normalperson @ 2014-02-28 16:42 UTC (permalink / raw)
  To: ruby-core

Issue #9577 has been updated by Eric Wong.


 SASADA Koichi <ko1@atdot.net> wrote:
 > (2014/02/28 16:44), normalperson@yhbt.net wrote:
 > > It is easier to read output when columns are aligned properly.
 > > I have an 80 column terminal, that's HUGE!  Use it :D
 > 
 > Sorry, I can't read .gz file because of my environment.
 
 unzipped versions:
 before: http://80x24.org/bmlog-20140126-003136.7320.txt
 after:  http://80x24.org/bmlog-20140228-071544.1805.txt
 
 > What happen when many executables are specified (over 80 chars)?
 
 This the timing lines after the text source is just aligned to the
 longest line, so it looks like this:
 
 	ruby 2.2.0dev (2014-02-28 trunk 45211) [x86_64-linux]   0.071003417
 	built-ruby                                              0.0817603
 
 Execution time summary header isn't changed, but the times themselves
 look much better:
 
 	Execution time (sec)
 	name	ruby 2.2.0dev (2014-02-28 trunk 45211) [x86_64-linux]	built-ruby
 	app_answer                         0.071    0.082
 	app_aobench                       84.672   84.014
 	app_erb                            1.511    1.524
 
 I didn't check the speedup ratio header, but maybe the "name\tbuilt-ruby"
 looks a little odd.  I can fix that.  The first line
 ("compare with the result of") is unchanged (and too long, but I don't
 read that).
 
 	Speedup ratio: compare with the result of `ruby 2.2.0dev (2014-02-28 trunk 45211) [x86_64-linux]' (greater is better)
 	name	built-ruby
 	app_answer                         0.868
 	app_aobench                        1.008
 	app_erb                            0.992

----------------------------------------
Feature #9577: [PATCH] benchmark/driver.rb: align columns in text output
https://bugs.ruby-lang.org/issues/9577#change-45521

* Author: Eric Wong
* Status: Open
* Priority: Low
* Assignee: Eric Wong
* Category: misc
* Target version: current: 2.2.0
----------------------------------------
It is easier to read output when columns are aligned properly.
I have an 80 column terminal, that's HUGE!  Use it :D

pulL: git://80x24.org/ruby.git bmdriver-align
patch: http://bogomips.org/ruby.git/patch?id=32eed05c80

samples
before: http://80x24.org/bmlog-20140126-003136.7320.gz
after:  http://80x24.org/bmlog-20140228-071544.1805.gz

I'll commit soon unless this breaks some tools (or this makes life hard
for the 40-column people :P)




-- 
http://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [ruby-core:90191] [Ruby trunk Feature#9577][Closed] [PATCH] benchmark/driver.rb: align columns in text output
       [not found] <redmine.issue-9577.20140228074416@ruby-lang.org>
                   ` (2 preceding siblings ...)
  2014-02-28 16:42 ` [ruby-core:61148] " normalperson
@ 2018-11-30 14:33 ` takashikkbn
  3 siblings, 0 replies; 6+ messages in thread
From: takashikkbn @ 2018-11-30 14:33 UTC (permalink / raw)
  To: ruby-core

Issue #9577 has been updated by k0kubun (Takashi Kokubun).

Status changed from Open to Closed

I think this was already fixed by introducing benchmark-driver.

~~~
$ make benchmark OPTS="-r time -o simple" ITEM=app_
../revision.h unchanged
/home/k0kubun/.rbenv/shims/ruby --disable=gems -rrubygems -I../benchmark/lib ../benchmark/benchmark-driver/exe/benchmark-driver \
            --executables="compare-ruby::/home/k0kubun/.rbenv/shims/ruby --disable=gems -I.ext/common --disable-gem" \
            --executables="built-ruby::./miniruby -I../lib -I. -I.ext/common  -r../prelude --disable-gem" \
            $(find ../benchmark -maxdepth 1 -name '*app_*.yml' -o -name '*app_*.rb' | sort) -r time -o simple
Execution time (s):
                 compare-ruby  built-ruby
app_answer             0.022        0.019
app_aobench           31.575       30.098
app_erb                0.632        1.311
~~~

----------------------------------------
Feature #9577: [PATCH] benchmark/driver.rb: align columns in text output
https://bugs.ruby-lang.org/issues/9577#change-75313

* Author: normalperson (Eric Wong)
* Status: Closed
* Priority: Normal
* Assignee: normalperson (Eric Wong)
* Target version: 
----------------------------------------
It is easier to read output when columns are aligned properly.
I have an 80 column terminal, that's HUGE!  Use it :D

pulL: git://80x24.org/ruby.git bmdriver-align
patch: http://bogomips.org/ruby.git/patch?id=32eed05c80

samples
before: http://80x24.org/bmlog-20140126-003136.7320.gz
after:  http://80x24.org/bmlog-20140228-071544.1805.gz

I'll commit soon unless this breaks some tools (or this makes life hard
for the 40-column people :P)




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-11-30 14:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <redmine.issue-9577.20140228074416@ruby-lang.org>
2014-02-28  7:44 ` [ruby-core:61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output normalperson
2014-02-28 12:26   ` [ruby-core:61144] " SASADA Koichi
2014-02-28 16:38     ` [ruby-core:61146] " Eric Wong
2014-02-28 12:30 ` [ruby-core:61145] [ruby-trunk - Feature #9577] " ko1
2014-02-28 16:42 ` [ruby-core:61148] " normalperson
2018-11-30 14:33 ` [ruby-core:90191] [Ruby trunk Feature#9577][Closed] " takashikkbn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).