ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: Greg.mpls@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90179] [Ruby trunk Bug#15354] Remove Bundler from StdLib
Date: Fri, 30 Nov 2018 00:49:49 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-75302.20181130004948.c14e4f068b7c0222@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15354.20181128171101@ruby-lang.org

Issue #15354 has been updated by MSP-Greg (Greg L).


@colby

Ok.  I decided on the longer message.

> snide comment

Snide - 'derogatory or mocking in an indirect way'.  @vo.x's comment is direct, and his point about the vendored libraries is valid.

> (Bundler) has had to deal with lots of issues from the RubyGems/Ruby project

Something just seems backward...

Just a few minutes ago, I came across a test in RubyGems that had three nested unless/end pairs, and only the innermost had any code.  So, I thought about a PR to clean it up; my first thought was who would ask 'what does this fix?'.

Also in RG, IMHO, there's code where process x and process y have become so tangled that they need to be pulled apart to allow other code to work correctly.  The tangling also mucks up testing.  I've procrastinated just because...

Conversely, here in ruby/ruby, the attitude is much more about improvement of any type.

Moving on, what are your thoughts on:

1. In what way should ruby/RubyGems/Bundler be integrated?
2. What to do about the vendored/duplicated libraries?
3. Given your involvement in both Bundler & RubyGems, and assuming infinite resources, what should change?

Thanks, Greg

----------------------------------------
Bug #15354:  Remove Bundler from StdLib
https://bugs.ruby-lang.org/issues/15354#change-75302

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
* ruby -v: ruby 2.6.0dev (2018-11-26 trunk 65990) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
[This is mostly a clone of #13978 which I opened a year ago. Unfortunately, the same points I mentioned there still hold true.]

I understand that given that almost every Ruby user is using Bundler, it would be convenient for quite some people to have Bundler as part of StdLib.

However, seeing two copies of Molinillo, each in a different version [1], [2], similarly to fileutils [3], [4], is a sign that things are not as they should be. Therefore, please consider removal of Bundler from StdLib unless upstream demonstrates it can maintain it properly.


[1]: https://github.com/ruby/ruby/blob/trunk/lib/bundler/vendor/molinillo/lib/molinillo/gem_metadata.rb#L5
[2]: https://github.com/ruby/ruby/blob/trunk/lib/rubygems/resolver/molinillo/lib/molinillo/gem_metadata.rb#L4
[3]: https://github.com/ruby/ruby/blob/trunk/lib/bundler/vendor/fileutils/lib/fileutils.rb
[4]: https://github.com/ruby/ruby/blob/trunk/lib/fileutils.rb



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2018-11-30  0:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15354.20181128171101@ruby-lang.org>
2018-11-28 17:11 ` [ruby-core:90125] [Ruby trunk Bug#15354] Remove Bundler from StdLib v.ondruch
2018-11-28 17:13 ` [ruby-core:90128] " leamhall
2018-11-28 17:41 ` [ruby-core:90129] " shevegen
2018-11-28 22:53 ` [ruby-core:90139] [Ruby trunk Bug#15354][Assigned] " hsbt
2018-11-29  5:51 ` [ruby-core:90152] [Ruby trunk Bug#15354] " Greg.mpls
2018-11-29  6:35 ` [ruby-core:90154] " v.ondruch
2018-11-29 23:09 ` [ruby-core:90178] " colby
2018-11-30  0:49 ` Greg.mpls [this message]
2018-11-30  1:01 ` [ruby-core:90180] [Ruby trunk Bug#15354][Rejected] " hsbt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-75302.20181130004948.c14e4f068b7c0222@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).