ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: hsbt@ruby-lang.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:82664] [Ruby trunk Feature#12733] Bundle bundler to ruby core
Date: Wed, 06 Sep 2017 02:37:18 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-66493.20170906023716.e08b76dcc23cf838@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-12733.20160907060543@ruby-lang.org

Issue #12733 has been updated by hsbt (Hiroshi SHIBATA).


I update my working branch.

https://github.com/ruby/ruby/pull/1536

Changes in this branch:

1. Directory Structure

I organized bundler integration like this:

```
  root -+- lib -+- bundler/*
            |          |
            |          +- bundler.gemspec
            |          |
            |          +- rubygems
            |          |
            |
            |
            +- spec -+- bundler/*
                            |
                            +- rubyspec
                            |

```

Differences from bundler repo are gemspec and rspec examples locations.
I'm going to send a pull request adopting Ruby core directory structure to bundler upstream.

2. Exclude some rspec examples for Ruby core.

Some of the bundler examples need to installed Ruby interpreter. But Ruby core test suite doesn't
use installed ruby interpreter. Therefore, It is necessary to exclude examples that require the
installed ruby interpreter.

I also send a pull request these exclusions used rspec filter condition to bundler repo.

Finally, We need to show results of "test-bundler" on Ruby CI (https://rubyci.org).
I will make patches for bundler integration to ruby/rubyci and ruby/chkbuild.











----------------------------------------
Feature #12733: Bundle bundler to ruby core
https://bugs.ruby-lang.org/issues/12733#change-66493

* Author: hsbt (Hiroshi SHIBATA)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 2.5
----------------------------------------
rubygems team has plan to migrate bundler into rubygems at rubygems 3.0.

ref. https://github.com/rubygems/rubygems/issues/1681

In current status, rubygems only use `Bundler` module on test suites.
But we should track rubygems upstream step by step. I propose to bundle bundler
for stdlib as default gem on ruby core repository.

but we have some consideration. such as

 * bundler uses rspec for test suites. How to use rspec on ruby core repository?
 * Who are maintain bundler on ruby core repository?

This issue is epic topic. Please comment your concerns or idea. 



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2017-09-06  2:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-12733.20160907060543@ruby-lang.org>
2016-09-07  6:05 ` [ruby-core:77172] [Ruby trunk Feature#12733] Bundle bundler to ruby core hsbt
2016-09-07  7:28 ` [ruby-core:77184] " eregontp
2016-09-09 16:48 ` [ruby-core:77231] " v.ondruch
2016-09-12  5:13 ` [ruby-core:77246] " duerst
2017-01-19  2:27 ` [ruby-core:79127] [Ruby trunk Feature#12733][Assigned] " hsbt
2017-03-13  5:46 ` [ruby-core:80100] [Ruby trunk Feature#12733] " hsbt
2017-06-22  1:18 ` [ruby-core:81737] " mail
2017-07-06  8:59 ` [ruby-core:81925] " hsbt
2017-07-06 18:49 ` [ruby-core:81936] " eregontp
2017-07-06 20:21   ` [ruby-core:81941] " Eduardo Souza
2017-07-09 14:00 ` [ruby-core:81974] " v.ondruch
2017-07-11  3:34 ` [ruby-core:81996] " hsbt
2017-07-19 21:27 ` [ruby-core:82109] " mail
2017-07-27  5:11 ` [ruby-core:82190] " hsbt
2017-08-16  2:55 ` [ruby-core:82395] " shevegen
2017-08-31  7:19 ` [ruby-core:82567] " matz
2017-09-06  2:37 ` hsbt [this message]
2017-09-06  4:39 ` [ruby-core:82666] " v.ondruch
2017-09-06  5:00 ` [ruby-core:82667] " shyouhei
2017-12-23  0:35 ` [ruby-core:84409] [Ruby trunk Feature#12733][Assigned] " hsbt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-66493.20170906023716.e08b76dcc23cf838@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).