ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: duerst@it.aoyama.ac.jp
To: ruby-core@ruby-lang.org
Subject: [ruby-core:77246] [Ruby trunk Feature#12733] Bundle bundler to ruby core
Date: Mon, 12 Sep 2016 05:13:34 +0000	[thread overview]
Message-ID: <redmine.journal-60480.20160912051334.6d7c2ddb1bb0232b@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-12733.20160907060543@ruby-lang.org

Issue #12733 has been updated by Martin Dürst.


Vit Ondruch wrote:

> Not only this, but the test suite also needs connection to internet to succeed. No other test needs this so far and I hope it will stay like that.

There are many parts in Ruby that (would) need connection to the Internet for decent testing. Webrick, open_uri, net::http, and so on immediately come to my mind. Also rubygems of course. Also several i18n-related tests (for String#unicode_normalize/upcase/downcase/...), where data needs to be downloaded from the unicode.org Web site if not yet available.

In the case of the i18n tests, they get skipped if the Internet connection fails. My guess is that all the other components that I mention do something similar. So this should also be possible for bundler, even if it's not yet the case.

In general, it would be a bad idea to not have tests that try to connect to the Internet and exercise the relevant functionality, in particular for a language such as Ruby where one of the very big areas of use in Internet/Web related. But of course, it has also to be possible to test (to the extent possible) in a standalone environment.

----------------------------------------
Feature #12733: Bundle bundler to ruby core
https://bugs.ruby-lang.org/issues/12733#change-60480

* Author: Hiroshi SHIBATA
* Status: Open
* Priority: Normal
* Assignee: Hiroshi SHIBATA
----------------------------------------
rubygems team has plan to migrate bundler into rubygems at rubygems 3.0.

ref. https://github.com/rubygems/rubygems/issues/1681

In current status, rubygems only use `Bundler` module on test suites.
But we should track rubygems upstream step by step. I propose to bundle bundler
for stdlib as default gem on ruby core repository.

but we have some consideration. such as

 * bundler uses rspec for test suites. How to use rspec on ruby core repository?
 * Who are maintain bundler on ruby core repository?

This issue is epic topic. Please comment your concerns or idea. 



-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2016-09-12  4:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-12733.20160907060543@ruby-lang.org>
2016-09-07  6:05 ` [ruby-core:77172] [Ruby trunk Feature#12733] Bundle bundler to ruby core hsbt
2016-09-07  7:28 ` [ruby-core:77184] " eregontp
2016-09-09 16:48 ` [ruby-core:77231] " v.ondruch
2016-09-12  5:13 ` duerst [this message]
2017-01-19  2:27 ` [ruby-core:79127] [Ruby trunk Feature#12733][Assigned] " hsbt
2017-03-13  5:46 ` [ruby-core:80100] [Ruby trunk Feature#12733] " hsbt
2017-06-22  1:18 ` [ruby-core:81737] " mail
2017-07-06  8:59 ` [ruby-core:81925] " hsbt
2017-07-06 18:49 ` [ruby-core:81936] " eregontp
2017-07-06 20:21   ` [ruby-core:81941] " Eduardo Souza
2017-07-09 14:00 ` [ruby-core:81974] " v.ondruch
2017-07-11  3:34 ` [ruby-core:81996] " hsbt
2017-07-19 21:27 ` [ruby-core:82109] " mail
2017-07-27  5:11 ` [ruby-core:82190] " hsbt
2017-08-16  2:55 ` [ruby-core:82395] " shevegen
2017-08-31  7:19 ` [ruby-core:82567] " matz
2017-09-06  2:37 ` [ruby-core:82664] " hsbt
2017-09-06  4:39 ` [ruby-core:82666] " v.ondruch
2017-09-06  5:00 ` [ruby-core:82667] " shyouhei
2017-12-23  0:35 ` [ruby-core:84409] [Ruby trunk Feature#12733][Assigned] " hsbt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-60480.20160912051334.6d7c2ddb1bb0232b@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).