[ruby-core:81714] [Ruby trunk Feature#13665] String#delete_suffix

[ruby-core:81714] [Ruby trunk Feature#13665] String#delete_suffix

[sonots]

Issue #13665 has been reported by sonots (Naotoshi Seo).

----------------------------------------
Feature #13665: String#delete_suffix
https://bugs.ruby-lang.org/issues/13665

* Author: sonots (Naotoshi Seo)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
In https://bugs.ruby-lang.org/issues/12694, we decided to have `String#delete_prefix`.
It would be nice to have `String#delete_suffix` method to delete suffix from a string for symmetry although it can be achieved with `String#chomp` as:

```
class String
  def delete_suffix(substr)
    chomp(substr)
  end
  def delete_suffix!(substr)
    chomp!(substr)
  end
end
```

Any opinions?



-- 
https://bugs.ruby-lang.org/

[ruby-core:81716] [Ruby trunk Feature#13665] String#delete_suffix

[nobu]

Issue #13665 has been updated by nobu (Nobuyoshi Nakada).

Description updated

At yesterday meeting, a name `lchomp` was proposed but rejected because of the special deal of CR LF.
If `delete_suffix` will be introduced, it should keep CR before LF when the argument is LF only, as well as `delete_prefix`.

----------------------------------------
Feature #13665: String#delete_suffix
https://bugs.ruby-lang.org/issues/13665#change-65415

* Author: sonots (Naotoshi Seo)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
In https://bugs.ruby-lang.org/issues/12694, we decided to have `String#delete_prefix`.
It would be nice to have `String#delete_suffix` method to delete suffix from a string for symmetry although it can be achieved with `String#chomp` as:

```ruby
class String
  def delete_suffix(substr)
    chomp(substr)
  end
  def delete_suffix!(substr)
    chomp!(substr)
  end
end
```

Any opinions?



-- 
https://bugs.ruby-lang.org/

[ruby-core:81735] [Ruby trunk Feature#13665] String#delete_suffix

[shevegen]

Issue #13665 has been updated by shevegen (Robert A. Heiler).


I think the method's functionality is good to have.

----------------------------------------
Feature #13665: String#delete_suffix
https://bugs.ruby-lang.org/issues/13665#change-65435

* Author: sonots (Naotoshi Seo)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
In https://bugs.ruby-lang.org/issues/12694, we decided to have `String#delete_prefix`.
It would be nice to have `String#delete_suffix` method to delete suffix from a string for symmetry although it can be achieved with `String#chomp` as:

```ruby
class String
  def delete_suffix(substr)
    chomp(substr)
  end
  def delete_suffix!(substr)
    chomp!(substr)
  end
end
```

Any opinions?



-- 
https://bugs.ruby-lang.org/

[ruby-core:81772] [Ruby trunk Feature#13665] String#delete_suffix

[sonots]

Issue #13665 has been updated by sonots (Naotoshi Seo).


I've sent a PR https://github.com/ruby/ruby/pull/1661.
I will merge if I get agreement at a ruby developer's meeting.

----------------------------------------
Feature #13665: String#delete_suffix
https://bugs.ruby-lang.org/issues/13665#change-65469

* Author: sonots (Naotoshi Seo)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
In https://bugs.ruby-lang.org/issues/12694, we decided to have `String#delete_prefix`.
It would be nice to have `String#delete_suffix` method to delete suffix from a string for symmetry although it can be achieved with `String#chomp` as:

```ruby
class String
  def delete_suffix(substr)
    chomp(substr)
  end
  def delete_suffix!(substr)
    chomp!(substr)
  end
end
```

Any opinions?



-- 
https://bugs.ruby-lang.org/

[ruby-core:82045] [Ruby trunk Feature#13665] String#delete_suffix

[matz]

Issue #13665 has been updated by matz (Yukihiro Matsumoto).


Looks good to me.

Matz.


----------------------------------------
Feature #13665: String#delete_suffix
https://bugs.ruby-lang.org/issues/13665#change-65772

* Author: sonots (Naotoshi Seo)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
In https://bugs.ruby-lang.org/issues/12694, we decided to have `String#delete_prefix`.
It would be nice to have `String#delete_suffix` method to delete suffix from a string for symmetry although it can be achieved with `String#chomp` as:

```ruby
class String
  def delete_suffix(substr)
    chomp(substr)
  end
  def delete_suffix!(substr)
    chomp!(substr)
  end
end
```

Any opinions?



-- 
https://bugs.ruby-lang.org/