ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:81720] [Ruby trunk Bug#13591] spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ']
Date: Mon, 19 Jun 2017 13:02:27 +0000	[thread overview]
Message-ID: <redmine.journal-65419.20170619130226.d0a39a9f3f35a695@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-13591.20170523141528@ruby-lang.org

Issue #13591 has been updated by Eregon (Benoit Daloze).


Fixed in r59113.
I split the spec to only include cases that seem to work on Windows according Greg's tests.
This test is inherently dependent on the OS parsing function for TZ, so we need to deal with those differences.

----------------------------------------
Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ']
https://bugs.ruby-lang.org/issues/13591#change-65419

* Author: MSP-Greg (Greg L)
* Status: Closed
* Priority: Normal
* Assignee: Eregon (Benoit Daloze)
* Target version: 
* ruby -v: ruby 2.5.0dev (2017-05-27 trunk 58911) [x64-mswin64_140]
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
Windows does not support ENV['TZ'], so it should be removed from rspec tests.

See [GitHub PR 1627](https://github.com/ruby/ruby/pull/1627)



-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2017-06-19 13:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-13591.20170523141528@ruby-lang.org>
2017-05-23 14:15 ` [ruby-core:81347] [Ruby trunk Bug#13591] spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] Greg.mpls
2017-05-23 14:29 ` [ruby-core:81348] [Ruby trunk Bug#13591][Rejected] " usa
2017-05-23 15:39 ` [ruby-core:81354] [Ruby trunk Bug#13591] " Greg.mpls
2017-05-23 17:33 ` [ruby-core:81357] " usa
2017-05-27  2:46 ` [ruby-core:81408] " Greg.mpls
2017-05-27  5:18 ` [ruby-core:81410] " nobu
2017-05-27  5:53 ` [ruby-core:81412] " Greg.mpls
2017-05-27  9:33 ` [ruby-core:81415] " eregontp
2017-05-27 10:26 ` [ruby-core:81418] [Ruby trunk Bug#13591][Feedback] " naruse
2017-05-27 15:46 ` [ruby-core:81421] [Ruby trunk Bug#13591] " Greg.mpls
2017-05-27 17:25 ` [ruby-core:81422] " eregontp
2017-05-27 18:39 ` [ruby-core:81423] " Greg.mpls
2017-06-19 13:02 ` eregontp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-65419.20170619130226.d0a39a9f3f35a695@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).