From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 548DA1FA7B for ; Mon, 19 Jun 2017 13:02:50 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 5757C120767; Mon, 19 Jun 2017 22:02:48 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 1D845120766 for ; Mon, 19 Jun 2017 22:02:45 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=8U7bVyhE2AZ5dPXWDGn/x9y3YkI=; b=xr9yb8cUfFqWBcxUmF tApouRlySp9EZr3PoIK1OTPn7L0RWH+V3kou5kcURLDsv+mo1ZwVfvFYyPwsdoQp ENEYPhG/MCTzQT82sPL/cGRc5QPjKYz5UarJkUFVXVmz9+5GZgks8xjE6eJtIoBm a0dtu6y9W0AiYmep/h+xbZTyg= Received: by filter0996p1mdw1.sendgrid.net with SMTP id filter0996p1mdw1-25773-5947CB63-38 2017-06-19 13:02:27.215642262 +0000 UTC Received: from herokuapp.com (ec2-54-221-151-206.compute-1.amazonaws.com [54.221.151.206]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id ymGzsf1FQ7yOUPiRoLWg1Q Mon, 19 Jun 2017 13:02:27.206 +0000 (UTC) Date: Mon, 19 Jun 2017 13:02:27 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56749 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13591 X-Redmine-Issue-Author: MSP-Greg X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6IBUixIPT9aibu7TF28/jE4NvtL2Tz3KCmQQ WIagOTjp44kLnqi7/mjEkWQCKDFGJRJW6CM81bJ6QwIV+LQmq5bbhDkxM0f04eEQN0ooLSUuFxV47F mGXc1hzlquMeawPPWCR3iO/HWAQb690jG9CBXqDPhPpTr4hjei0Nldv5Tw== X-ML-Name: ruby-core X-Mail-Count: 81720 Subject: [ruby-core:81720] [Ruby trunk Bug#13591] spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13591 has been updated by Eregon (Benoit Daloze). Fixed in r59113. I split the spec to only include cases that seem to work on Windows according Greg's tests. This test is inherently dependent on the OS parsing function for TZ, so we need to deal with those differences. ---------------------------------------- Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] https://bugs.ruby-lang.org/issues/13591#change-65419 * Author: MSP-Greg (Greg L) * Status: Closed * Priority: Normal * Assignee: Eregon (Benoit Daloze) * Target version: * ruby -v: ruby 2.5.0dev (2017-05-27 trunk 58911) [x64-mswin64_140] * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Windows does not support ENV['TZ'], so it should be removed from rspec tests. See [GitHub PR 1627](https://github.com/ruby/ruby/pull/1627) -- https://bugs.ruby-lang.org/