[ruby-core:77219] [Ruby trunk Feature#12739] deprecate_constant :Fixnum, :Bignum

[ruby-core:77219] [Ruby trunk Feature#12739] deprecate_constant :Fixnum, :Bignum

[zn]

Issue #12739 has been reported by Kazuhiro NISHIYAMA.

----------------------------------------
Feature #12739: deprecate_constant :Fixnum, :Bignum
https://bugs.ruby-lang.org/issues/12739

* Author: Kazuhiro NISHIYAMA
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?

* naruse supports: https://twitter.com/nalsh/status/773800491671101441
* akr objects: https://twitter.com/tanaka_akr/status/773817391218249729

I don't mind either way.
Do you have any comment about it?



-- 
https://bugs.ruby-lang.org/

[ruby-core:77240] [Ruby trunk Feature#12739] deprecate_constant :Fixnum, :Bignum

[nobu]

Issue #12739 has been updated by Nobuyoshi Nakada.


I tried [this], found rake defines `Fixnum::MAX` which seems useless, and submitted a [PR] to rake.
But it fails on ruby 2.2 or earlier, due to incompatibility of Bundler 1.13.0.

[this]: https://github.com/ruby/ruby/compare/trunk...nobu:feature/12739-deprecate-fixnum-bignum
[PR]: https://github.com/ruby/rake/pull/160


----------------------------------------
Feature #12739: deprecate_constant :Fixnum, :Bignum
https://bugs.ruby-lang.org/issues/12739#change-60464

* Author: Kazuhiro NISHIYAMA
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?

* naruse supports: https://twitter.com/nalsh/status/773800491671101441
* akr objects: https://twitter.com/tanaka_akr/status/773817391218249729

I don't mind either way.
Do you have any comment about it?



-- 
https://bugs.ruby-lang.org/

[ruby-core:81570] [Ruby trunk Feature#12739] deprecate_constant :Fixnum, :Bignum

[rob]

Issue #12739 has been updated by robertgleeson (Robert Gleeson).


znz (Kazuhiro NISHIYAMA) wrote:
> How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?
> 
> * naruse supports: https://twitter.com/nalsh/status/773800491671101441
> * akr objects: https://twitter.com/tanaka_akr/status/773817391218249729
> 
> I don't mind either way.
> Do you have any comment about it?

It would be nice to have `constant_deprecated?`.
To avoid all of these warnings while supporting <2.4 and >=2.4 i track what constants are deprecated in an array, and 
then avoid using them or not by checking the array at runtime. It's bit of a pain..


----------------------------------------
Feature #12739: deprecate_constant :Fixnum, :Bignum
https://bugs.ruby-lang.org/issues/12739#change-65272

* Author: znz (Kazuhiro NISHIYAMA)
* Status: Closed
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?

* naruse supports: https://twitter.com/nalsh/status/773800491671101441
* akr objects: https://twitter.com/tanaka_akr/status/773817391218249729

I don't mind either way.
Do you have any comment about it?



-- 
https://bugs.ruby-lang.org/

[ruby-core:81571] [Ruby trunk Feature#12739] deprecate_constant :Fixnum, :Bignum

[rob]

Issue #12739 has been updated by robertgleeson (Robert Gleeson).


robertgleeson (Robert Gleeson) wrote:
> znz (Kazuhiro NISHIYAMA) wrote:
> > How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?
> > 
> > * naruse supports: https://twitter.com/nalsh/status/773800491671101441
> > * akr objects: https://twitter.com/tanaka_akr/status/773817391218249729
> > 
> > I don't mind either way.
> > Do you have any comment about it?
> 
> It would be nice to have `constant_deprecated?`.
> To avoid all of these warnings while supporting <2.4 and >=2.4 i track what constants are deprecated in an array, and 
> then avoid using them or not by checking the array at runtime. It's bit of a pain..

I realise my comment isn't clear, here's very simple code to show what i mean:

deprecated_constants = [:Fixnum, :TimeoutError, :Bignum, :FALSE, :TRUE, :NIL]
Object.constants.each do |constant|
  const_get(constant) unless deprecated_constants.include?(constant) 
end

the real code i have is more complex, but in essence this is the problem,
and deprecated_constants has to be maintained by me manually, which
will become out of date over time.


----------------------------------------
Feature #12739: deprecate_constant :Fixnum, :Bignum
https://bugs.ruby-lang.org/issues/12739#change-65273

* Author: znz (Kazuhiro NISHIYAMA)
* Status: Closed
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?

* naruse supports: https://twitter.com/nalsh/status/773800491671101441
* akr objects: https://twitter.com/tanaka_akr/status/773817391218249729

I don't mind either way.
Do you have any comment about it?



-- 
https://bugs.ruby-lang.org/

[ruby-core:81711] [Ruby trunk Feature#12739] deprecate_constant :Fixnum, :Bignum

[zn]

Issue #12739 has been updated by znz (Kazuhiro NISHIYAMA).


Closed ticket should not be reused.
Please open new ticket.

----------------------------------------
Feature #12739: deprecate_constant :Fixnum, :Bignum
https://bugs.ruby-lang.org/issues/12739#change-65409

* Author: znz (Kazuhiro NISHIYAMA)
* Status: Closed
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?

* naruse supports: https://twitter.com/nalsh/status/773800491671101441
* akr objects: https://twitter.com/tanaka_akr/status/773817391218249729

I don't mind either way.
Do you have any comment about it?



-- 
https://bugs.ruby-lang.org/