* [ruby-core:110873] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts
@ 2022-11-24 10:32 vo.x (Vit Ondruch)
2022-11-24 11:21 ` [ruby-core:110875] " mame (Yusuke Endoh)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: vo.x (Vit Ondruch) @ 2022-11-24 10:32 UTC (permalink / raw)
To: ruby-core
Issue #19145 has been reported by vo.x (Vit Ondruch).
----------------------------------------
Bug #19145: TestException#test_exception_in_message timeouts
https://bugs.ruby-lang.org/issues/19145
* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
Testing with 66e5200ba4, I observe following error:
~~~
$ make -C redhat-linux-build test-all 'TESTS=-v -n /TestException#test_exception_in_message/' 'MSPECOPT=-fs '
make: Entering directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
Run options:
--seed=50244
"--ruby=./miniruby -I/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/lib -I. -I.ext/common /builddir/build/BUILD/ruby-3.2.0-66e5200ba4/tool/runruby.rb --extout=.ext -- --disable-gems"
--excludes-dir=/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/test/excludes
--name=!/memory_leak/
-v
-n
/TestException#test_exception_in_message/
# Running tests:
[1/0] TestException#test_exception_in_message = 3.10 sT
1) Timeout:
TestException#test_exception_in_message
Finished tests in 6.405179s, 0.1561 tests/s, 0.3122 assertions/s.
1 tests, 2 assertions, 0 failures, 1 errors, 0 skips
ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
make: *** [uncommon.mk:855: yes-test-all] Error 1
make: Leaving directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
~~~
Last time I was testing with 4b1504ae0a beginning of November and there was not issue
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 4+ messages in thread* [ruby-core:110875] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts
2022-11-24 10:32 [ruby-core:110873] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts vo.x (Vit Ondruch)
@ 2022-11-24 11:21 ` mame (Yusuke Endoh)
2022-11-24 14:37 ` [ruby-core:110879] " nobu (Nobuyoshi Nakada)
2022-12-01 17:55 ` [ruby-core:111134] " vo.x (Vit Ondruch)
2 siblings, 0 replies; 4+ messages in thread
From: mame (Yusuke Endoh) @ 2022-11-24 11:21 UTC (permalink / raw)
To: ruby-core
Issue #19145 has been updated by mame (Yusuke Endoh).
Assignee set to nobu (Nobuyoshi Nakada)
I think it has been happening since @nobu tweaked the exit process for https://bugs.ruby-lang.org/issues/19016.
----------------------------------------
Bug #19145: TestException#test_exception_in_message timeouts
https://bugs.ruby-lang.org/issues/19145#change-100234
* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
Testing with 66e5200ba4, I observe following error:
~~~
$ make -C redhat-linux-build test-all 'TESTS=-v -n /TestException#test_exception_in_message/' 'MSPECOPT=-fs '
make: Entering directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
Run options:
--seed=50244
"--ruby=./miniruby -I/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/lib -I. -I.ext/common /builddir/build/BUILD/ruby-3.2.0-66e5200ba4/tool/runruby.rb --extout=.ext -- --disable-gems"
--excludes-dir=/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/test/excludes
--name=!/memory_leak/
-v
-n
/TestException#test_exception_in_message/
# Running tests:
[1/0] TestException#test_exception_in_message = 3.10 sT
1) Timeout:
TestException#test_exception_in_message
Finished tests in 6.405179s, 0.1561 tests/s, 0.3122 assertions/s.
1 tests, 2 assertions, 0 failures, 1 errors, 0 skips
ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
make: *** [uncommon.mk:855: yes-test-all] Error 1
make: Leaving directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
~~~
Last time I was testing with 4b1504ae0a beginning of November and there was not issue
--
https://bugs.ruby-lang.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ruby-core:110879] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts
2022-11-24 10:32 [ruby-core:110873] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts vo.x (Vit Ondruch)
2022-11-24 11:21 ` [ruby-core:110875] " mame (Yusuke Endoh)
@ 2022-11-24 14:37 ` nobu (Nobuyoshi Nakada)
2022-12-01 17:55 ` [ruby-core:111134] " vo.x (Vit Ondruch)
2 siblings, 0 replies; 4+ messages in thread
From: nobu (Nobuyoshi Nakada) @ 2022-11-24 14:37 UTC (permalink / raw)
To: ruby-core
Issue #19145 has been updated by nobu (Nobuyoshi Nakada).
Does this work?
```diff
diff --git a/eval_error.c b/eval_error.c
index 0112dece0d1..7f184691e50 100644
--- a/eval_error.c
+++ b/eval_error.c
@@ -443,6 +443,15 @@ exiting_split(VALUE errinfo, volatile int *exitcode, volatile int *sigstatus)
if (NIL_P(errinfo)) return 0;
+ VALUE eclass = CLASS_OF(errinfo);
+ const VALUE *special_exceptions = GET_VM()->special_exceptions;
+ for (enum ruby_special_exceptions i = 0; i < ruby_special_error_count; ++i) {
+ if (eclass == special_exceptions[i]) {
+ if (exitcode) *exitcode = EXIT_FAILURE;
+ return EXITING_WITH_STATUS;
+ }
+ }
+
if (rb_obj_is_kind_of(errinfo, rb_eSystemExit)) {
ex = sysexit_status(errinfo);
result |= EXITING_WITH_STATUS;
```
----------------------------------------
Bug #19145: TestException#test_exception_in_message timeouts
https://bugs.ruby-lang.org/issues/19145#change-100237
* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
Testing with 66e5200ba4, I observe following error:
~~~
$ make -C redhat-linux-build test-all 'TESTS=-v -n /TestException#test_exception_in_message/' 'MSPECOPT=-fs '
make: Entering directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
Run options:
--seed=50244
"--ruby=./miniruby -I/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/lib -I. -I.ext/common /builddir/build/BUILD/ruby-3.2.0-66e5200ba4/tool/runruby.rb --extout=.ext -- --disable-gems"
--excludes-dir=/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/test/excludes
--name=!/memory_leak/
-v
-n
/TestException#test_exception_in_message/
# Running tests:
[1/0] TestException#test_exception_in_message = 3.10 sT
1) Timeout:
TestException#test_exception_in_message
Finished tests in 6.405179s, 0.1561 tests/s, 0.3122 assertions/s.
1 tests, 2 assertions, 0 failures, 1 errors, 0 skips
ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
make: *** [uncommon.mk:855: yes-test-all] Error 1
make: Leaving directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
~~~
Last time I was testing with 4b1504ae0a beginning of November and there was not issue
--
https://bugs.ruby-lang.org/
^ permalink raw reply related [flat|nested] 4+ messages in thread* [ruby-core:111134] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts
2022-11-24 10:32 [ruby-core:110873] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts vo.x (Vit Ondruch)
2022-11-24 11:21 ` [ruby-core:110875] " mame (Yusuke Endoh)
2022-11-24 14:37 ` [ruby-core:110879] " nobu (Nobuyoshi Nakada)
@ 2022-12-01 17:55 ` vo.x (Vit Ondruch)
2 siblings, 0 replies; 4+ messages in thread
From: vo.x (Vit Ondruch) @ 2022-12-01 17:55 UTC (permalink / raw)
To: ruby-core
Issue #19145 has been updated by vo.x (Vit Ondruch).
Thx for the fix. With commit:git|0436f1e15a, I don't observe the timeout anymore.
----------------------------------------
Bug #19145: TestException#test_exception_in_message timeouts
https://bugs.ruby-lang.org/issues/19145#change-100413
* Author: vo.x (Vit Ondruch)
* Status: Closed
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
Testing with 66e5200ba4, I observe following error:
~~~
$ make -C redhat-linux-build test-all 'TESTS=-v -n /TestException#test_exception_in_message/' 'MSPECOPT=-fs '
make: Entering directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
Run options:
--seed=50244
"--ruby=./miniruby -I/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/lib -I. -I.ext/common /builddir/build/BUILD/ruby-3.2.0-66e5200ba4/tool/runruby.rb --extout=.ext -- --disable-gems"
--excludes-dir=/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/test/excludes
--name=!/memory_leak/
-v
-n
/TestException#test_exception_in_message/
# Running tests:
[1/0] TestException#test_exception_in_message = 3.10 sT
1) Timeout:
TestException#test_exception_in_message
Finished tests in 6.405179s, 0.1561 tests/s, 0.3122 assertions/s.
1 tests, 2 assertions, 0 failures, 1 errors, 0 skips
ruby -v: ruby 3.2.0dev (2022-11-24 master 66e5200ba4) [x86_64-linux]
make: *** [uncommon.mk:855: yes-test-all] Error 1
make: Leaving directory '/builddir/build/BUILD/ruby-3.2.0-66e5200ba4/redhat-linux-build'
~~~
Last time I was testing with 4b1504ae0a beginning of November and there was not issue
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-01 17:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 10:32 [ruby-core:110873] [Ruby master Bug#19145] TestException#test_exception_in_message timeouts vo.x (Vit Ondruch)
2022-11-24 11:21 ` [ruby-core:110875] " mame (Yusuke Endoh)
2022-11-24 14:37 ` [ruby-core:110879] " nobu (Nobuyoshi Nakada)
2022-12-01 17:55 ` [ruby-core:111134] " vo.x (Vit Ondruch)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).