[ruby-core:110523] [Ruby master Misc#19087] String#to_c supports "_"

[ruby-core:110523] [Ruby master Misc#19087] String#to_c supports "_"

[andrykonchin (Andrew Konchin)]

Issue #19087 has been reported by andrykonchin (Andrew Konchin).

----------------------------------------
Misc #19087: String#to_c supports "_"
https://bugs.ruby-lang.org/issues/19087

* Author: andrykonchin (Andrew Konchin)
* Status: Open
* Priority: Normal
----------------------------------------
I've noticed a minor inconsistent behaviour of `String#to_c` method. It does not treat a sequence of `_` character as an end of meaningful characters:

```ruby
"123".to_c # => (123+0i)
"12_3".to_c # => (123+0i)
"12__3".to_c # => (123+0i)
"12___3".to_c # => (123+0i)
```

Similar methods `#to_i` and `#to_r` treat multiple `_` in a different way - they just ignore characters after it:

```ruby
"12__3".to_i # => 12
"12__3".to_r # => (12/1)
```

I would expect `#to_c` to behave similarly.


---

```
$ ruby -v
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin21]
```




-- 
https://bugs.ruby-lang.org/

[ruby-core:110532] [Ruby master Bug#19087] String#to_c supports multiple "_"

[nobu (Nobuyoshi Nakada)]

Issue #19087 has been updated by nobu (Nobuyoshi Nakada).


https://github.com/ruby/ruby/pull/6645

----------------------------------------
Bug #19087: String#to_c supports multiple "_"
https://bugs.ruby-lang.org/issues/19087#change-99858

* Author: andrykonchin (Andrew Konchin)
* Status: Open
* Priority: Normal
* Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
I've noticed a minor inconsistent behaviour of `String#to_c` method. It does not treat a sequence of `_` character as an end of meaningful characters:

```ruby
"123".to_c # => (123+0i)
"12_3".to_c # => (123+0i)
"12__3".to_c # => (123+0i)
"12___3".to_c # => (123+0i)
```

Similar methods `#to_i` and `#to_r` treat multiple `_` in a different way - they just ignore characters after it:

```ruby
"12__3".to_i # => 12
"12__3".to_r # => (12/1)
```

I would expect `#to_c` to behave similarly.


---

```
$ ruby -v
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin21]
```




-- 
https://bugs.ruby-lang.org/

[ruby-core:110768] [Ruby master Bug#19087] String#to_c supports multiple "_"

[andrykonchin (Andrew Konchin)]

Issue #19087 has been updated by andrykonchin (Andrew Konchin).


Thank you!

----------------------------------------
Bug #19087: String#to_c supports multiple "_"
https://bugs.ruby-lang.org/issues/19087#change-100111

* Author: andrykonchin (Andrew Konchin)
* Status: Open
* Priority: Normal
* Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
I've noticed a minor inconsistent behaviour of `String#to_c` method. It does not treat a sequence of `_` character as an end of meaningful characters:

```ruby
"123".to_c # => (123+0i)
"12_3".to_c # => (123+0i)
"12__3".to_c # => (123+0i)
"12___3".to_c # => (123+0i)
```

Similar methods `#to_i` and `#to_r` treat multiple `_` in a different way - they just ignore characters after it:

```ruby
"12__3".to_i # => 12
"12__3".to_r # => (12/1)
```

I would expect `#to_c` to behave similarly.


---

```
$ ruby -v
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin21]
```




-- 
https://bugs.ruby-lang.org/

[ruby-core:111246] [Ruby master Bug#19087] String#to_c supports multiple "_"

[nagachika (Tomoyuki Chikanaga)]

Issue #19087 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED

I agree that the new behavior is consistent and preferable, but I don't think it should be fixed on the stable branches.
If there are any troubles on the real world applications with this issue, please let me know.

----------------------------------------
Bug #19087: String#to_c supports multiple "_"
https://bugs.ruby-lang.org/issues/19087#change-100537

* Author: andrykonchin (Andrew Konchin)
* Status: Closed
* Priority: Normal
* Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED
----------------------------------------
I've noticed a minor inconsistent behaviour of `String#to_c` method. It does not treat a sequence of `_` character as an end of meaningful characters:

```ruby
"123".to_c # => (123+0i)
"12_3".to_c # => (123+0i)
"12__3".to_c # => (123+0i)
"12___3".to_c # => (123+0i)
```

Similar methods `#to_i` and `#to_r` treat multiple `_` in a different way - they just ignore characters after it:

```ruby
"12__3".to_i # => 12
"12__3".to_r # => (12/1)
```

I would expect `#to_c` to behave similarly.


---

```
$ ruby -v
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin21]
```




-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/