ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: "tenderlovemaking (Aaron Patterson) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "tenderlovemaking (Aaron Patterson)" <noreply@ruby-lang.org>
Subject: [ruby-core:117313] [Ruby master Bug#20392] Delegate super calls with a block
Date: Mon, 25 Mar 2024 22:51:36 +0000 (UTC)	[thread overview]
Message-ID: <redmine.issue-20392.20240325225136.73@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-20392.20240325225136.73@ruby-lang.org

Issue #20392 has been reported by tenderlovemaking (Aaron Patterson).

----------------------------------------
Bug #20392: Delegate super calls with a block
https://bugs.ruby-lang.org/issues/20392

* Author: tenderlovemaking (Aaron Patterson)
* Status: Open
* ruby -v: ruby 3.4.0dev (2024-03-15T18:08:39Z master e3a82d79fd) [arm64-darwin23]
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
I'm seeing strange behavior with calls to `super` when combined with `...` and a block.  I'm not sure if this is expected behavior or not, so I'm filing this ticket.

Using delegate `...` with an explicit block will cause an error:

```ruby
# Example 1
def foo ...
  yield
end

def bar ...
  foo(...) { } # test.rb: test.rb:6: both block arg and actual block given (SyntaxError)
end
```

However, calling `super` and passing a block works:

```
# Example 2
class A
  def foo
    yield(3)
  end
end

class B < A
  def foo(...)
    super do |x|
      yield(2 + x)
    end
  end
end

p B.new.foo { |x| x } # 5
```

In the above code, I imagine the bare `super` to basically be equivalent of `super(...)` since I defined the method `foo` as `foo(...)`.

However, if I explicitly pass `...` to super, there is no syntax error, just the block I provided is ignored:

```ruby
# Example 3
class A
  def foo
    yield(3)
  end
end

class B < A
  def foo(...)
    super(...) do |x|
      raise "should I be called?"
    end
  end
end

p B.new.foo { |x| x } # 3
```

I'd expect Example 3 to raise an exception like Example 1.  Additionally, I think the behavior in Example 2 is odd, but zsupers are "special" so I can understand if it is intended behavior.

Is Example 3 intended behavior?  If not, how should it behave?

Thanks.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

       reply	other threads:[~2024-03-25 22:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 22:51 tenderlovemaking (Aaron Patterson) via ruby-core [this message]
2024-03-25 23:21 ` [ruby-core:117314] [Ruby master Bug#20392] Delegate super calls with a block Dan0042 (Daniel DeLorme) via ruby-core
2024-03-26  0:01 ` [ruby-core:117315] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-03-26  0:42 ` [ruby-core:117316] " tenderlovemaking (Aaron Patterson) via ruby-core
2024-03-26  0:57 ` [ruby-core:117317] " jeremyevans0 (Jeremy Evans) via ruby-core
2024-03-26  1:11 ` [ruby-core:117318] " nobu (Nobuyoshi Nakada) via ruby-core
2024-03-26  1:12 ` [ruby-core:117319] " nobu (Nobuyoshi Nakada) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.issue-20392.20240325225136.73@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    --cc=noreply@ruby-lang.org \
    --cc=ruby-core@ml.ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).