From: "kddnewton (Kevin Newton) via ruby-core" <ruby-core@ml.ruby-lang.org>
To: ruby-core@ml.ruby-lang.org
Cc: "kddnewton (Kevin Newton)" <noreply@ruby-lang.org>
Subject: [ruby-core:117268] [Ruby master Feature#20384] RubyVM::InstructionSequence.{new,compile} use --parser option
Date: Wed, 20 Mar 2024 20:27:43 +0000 (UTC) [thread overview]
Message-ID: <redmine.issue-20384.20240320202742.10206@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-20384.20240320202742.10206@ruby-lang.org
Issue #20384 has been reported by kddnewton (Kevin Newton).
----------------------------------------
Feature #20384: RubyVM::InstructionSequence.{new,compile} use --parser option
https://bugs.ruby-lang.org/issues/20384
* Author: kddnewton (Kevin Newton)
* Status: Open
----------------------------------------
Right now we have `RubyVM::InstructionSequence.compile` and `RubyVM::InstructionSequence.compile_prism`. We introduced this API in order to properly test the integration, even when running with `--parser=parse.y`.
I'm running into issues, however, when tests are comparing between `eval` and `RubyVM::InstructionSequence.new`. The latter always uses `parse.y`, even if `--parser=prism` is passed on the command line. I would like to change that so that `RubyVM::InstructionSequence.{new,compile}` respects the `--parser` option so that it's consistent.
Would this change be okay? It would only impact processes with `--parser=prism`, so I don't imagine there's any kind of risk here.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- ruby-core@ml.ruby-lang.org
To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
next parent reply other threads:[~2024-03-20 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 20:27 kddnewton (Kevin Newton) via ruby-core [this message]
2024-03-29 15:18 ` [ruby-core:117376] [Ruby master Feature#20384] RubyVM::InstructionSequence.{new,compile} use --parser option kddnewton (Kevin Newton) via ruby-core
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-20384.20240320202742.10206@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
--cc=noreply@ruby-lang.org \
--cc=ruby-core@ml.ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).