ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:109845] [Ruby master Bug#18997] Don't define ruby_qsort when POSIX qsort_r is available
@ 2022-09-08  7:50 delphij (Xin Li)
  2023-03-25  1:37 ` [ruby-core:113004] " nagachika (Tomoyuki Chikanaga) via ruby-core
  0 siblings, 1 reply; 2+ messages in thread
From: delphij (Xin Li) @ 2022-09-08  7:50 UTC (permalink / raw)
  To: ruby-core

Issue #18997 has been reported by delphij (Xin Li).

----------------------------------------
Bug #18997: Don't define ruby_qsort when POSIX qsort_r is available
https://bugs.ruby-lang.org/issues/18997

* Author: delphij (Xin Li)
* Status: Open
* Priority: Normal
* ruby -v: Not applicable
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
The current code would define ruby_qsort as a wrapper of qsort_s when it is available. When both qsort_s and POSIX (GNU) qsort_r are available, we should call qsort_r directly instead, and the qsort_s wrapper is redundant.

Proposed patch at https://github.com/ruby/ruby/pull/6332 and can be applied on Ruby 2.7 and newer Ruby versions



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [ruby-core:113004] [Ruby master Bug#18997] Don't define ruby_qsort when POSIX qsort_r is available
  2022-09-08  7:50 [ruby-core:109845] [Ruby master Bug#18997] Don't define ruby_qsort when POSIX qsort_r is available delphij (Xin Li)
@ 2023-03-25  1:37 ` nagachika (Tomoyuki Chikanaga) via ruby-core
  0 siblings, 0 replies; 2+ messages in thread
From: nagachika (Tomoyuki Chikanaga) via ruby-core @ 2023-03-25  1:37 UTC (permalink / raw)
  To: ruby-core; +Cc: nagachika (Tomoyuki Chikanaga)

Issue #18997 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED

I don't think this is necessary to backport to stable branches.

----------------------------------------
Bug #18997: Don't define ruby_qsort when POSIX qsort_r is available
https://bugs.ruby-lang.org/issues/18997#change-102537

* Author: delphij (Xin Li)
* Status: Closed
* Priority: Normal
* ruby -v: Not applicable
* Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED
----------------------------------------
The current code would define ruby_qsort as a wrapper of qsort_s when it is available. When both qsort_s and POSIX (GNU) qsort_r are available, we should call qsort_r directly instead, and the qsort_s wrapper is redundant.

Proposed patch at https://github.com/ruby/ruby/pull/6332 and can be applied on Ruby 2.7 and newer Ruby versions



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-25  1:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08  7:50 [ruby-core:109845] [Ruby master Bug#18997] Don't define ruby_qsort when POSIX qsort_r is available delphij (Xin Li)
2023-03-25  1:37 ` [ruby-core:113004] " nagachika (Tomoyuki Chikanaga) via ruby-core

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).