ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: sos4nt <noreply@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:108294] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces
Date: Tue, 19 Apr 2022 14:42:09 +0000 (UTC)	[thread overview]
Message-ID: <redmine.issue-18743.20220419144209.7176@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-18743.20220419144209.7176@ruby-lang.org

Issue #18743 has been reported by sos4nt (Stefan Schüßler).

----------------------------------------
Bug #18743: Enumerator#next / peek re-use each others stacktraces
https://bugs.ruby-lang.org/issues/18743

* Author: sos4nt (Stefan Schüßler)
* Status: Open
* Priority: Normal
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
I encountered an odd behavior.

If I rescue the `StopIteration` exception from `peek` and call `next` afterwards: (or vice-versa)

```ruby
# enum.rb             # 1
                      # 2
enum = [].each        # 3
enum.peek rescue nil  # 4
enum.next             # 5
```

it will show the stacktrace from the rescued `peek` call:

```
$ ruby enum.rb
enum.rb:4:in `peek': iteration reached an end (StopIteration)
	from enum.rb:4:in `<main>'
```

Whereas the error should refer to `next` on line number 5.

The same happens when calling `peek` after `next` or when having muliple `peek` / `next` calls:

```ruby
# enum.rb                # 1
                         # 2
enum = [].each           # 3
enum.peek rescue nil     # 4
enum.next rescue nil     # 5
enum.peek rescue nil     # 6
puts "line #{__LINE__}"  # 7
enum.next                # 8
```

The stacktrace from the first (rescued) `peek` or `next` call will be shown which doesn't reflect the actual error location:

```
$ ruby enum.rb
line 7
enum.rb:4:in `peek': iteration reached an end (StopIteration)
	from enum.rb:4:in `<main>'
```

This is very confusing when debugging code.



-- 
https://bugs.ruby-lang.org/

       reply	other threads:[~2022-04-19 14:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 14:42 sos4nt [this message]
2022-07-29 13:54 ` [ruby-core:109366] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces marcper (Marcelo Pereira)
2022-09-04 14:50 ` [ruby-core:109841] " marcper (Marcelo Pereira)
2022-10-06  8:42 ` [ruby-core:110205] " marcper (Marcelo Pereira)
2022-10-23 13:09 ` [ruby-core:110491] " marcper (Marcelo Pereira)
2022-11-09  8:17 ` [ruby-core:110666] " marcper (Marcelo Pereira)
2022-12-29  8:56 ` [ruby-core:111498] " marcper (Marcelo Pereira) via ruby-core
2023-03-03  8:58 ` [ruby-core:112675] " marcper (Marcelo Pereira) via ruby-core
2023-03-09  6:26 ` [ruby-core:112763] " ko1 (Koichi Sasada) via ruby-core
2023-03-10  3:35 ` [ruby-core:112820] " matz (Yukihiro Matsumoto) via ruby-core
2023-03-18 14:28 ` [ruby-core:112941] " marcper (Marcelo Pereira) via ruby-core
2023-04-01 10:10 ` [ruby-core:113069] " marcper (Marcelo Pereira) via ruby-core
2023-05-16 13:03 ` [ruby-core:113497] " marcper (Marcelo Pereira) via ruby-core
2023-05-17  2:03 ` [ruby-core:113501] " nobu (Nobuyoshi Nakada) via ruby-core
2023-05-19 14:55 ` [ruby-core:113531] " marcper (Marcelo Pereira) via ruby-core
2023-06-07  6:48 ` [ruby-core:113786] " nobu (Nobuyoshi Nakada) via ruby-core
2023-06-26 19:41 ` [ruby-core:114024] " marcper (Marcelo Pereira) via ruby-core
2023-07-14 12:09 ` [ruby-core:114185] " marcper (Marcelo Pereira) via ruby-core
2023-10-29 11:38 ` [ruby-core:115195] " marcper (Marcelo Pereira) via ruby-core
2024-02-25  9:29 ` [ruby-core:116935] " nagachika (Tomoyuki Chikanaga) via ruby-core

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.issue-18743.20220419144209.7176@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).