ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: lxxxvi <noreply@ruby-lang.org>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:105607] [Ruby master Bug#18247] weird results for `Array#slice` or `Array#[]` with argument of type `Enumerator::ArithmeticSequence`
Date: Fri, 08 Oct 2021 15:38:39 +0000 (UTC)	[thread overview]
Message-ID: <redmine.issue-18247.20211008153838.51932@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-18247.20211008153838.51932@ruby-lang.org

Issue #18247 has been reported by lxxxvi (Mario Schüttel).

----------------------------------------
Bug #18247: weird results for `Array#slice` or `Array#[]` with argument of type `Enumerator::ArithmeticSequence`
https://bugs.ruby-lang.org/issues/18247

* Author: lxxxvi (Mario Schüttel)
* Status: Open
* Priority: Normal
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
There are weird results for `Array#slice` or `Array#[]` with argument of type `Enumerator::ArithmeticSequence`.

Particularly most results with negative steps are weird. For example:

```ruby
@array = [0, 1, 2, 3, 4, 5]

@array.slice((2..).step(-1))          # =>  [2, 1, 0]
@array.slice((2..).step(-2))          # =>  [2, 0]
@array.slice((2..).step(-3))          # =>  [2]
@array.slice((2..).step(-4))          # =>  [0]           # ???  I'd have expected [2]

@array.slice((-3..).step(-1))         # =>  [3, 2, 1, 0]
@array.slice((-3..).step(-2))         # =>  [3, 1]
@array.slice((-3..).step(-3))         # =>  [3, 0]
@array.slice((-3..).step(-4))         # =>  [3]
@array.slice((-3..).step(-5))         # =>  [0]           # ???  I'd have expected [3]
```

Have a look at these examples with "beginless" ranges and negative steps.
Particularly the ones exluding the end value (`...`) seem wrong:


```ruby
@array = [0, 1, 2, 3, 4, 5]

## end with zero index
@array.slice((..0).step(-1))        # =>  [5, 4, 3, 2, 1, 0]
@array.slice((...0).step(-1))       # =>  [5, 4, 3, 2, 1, 0]

@array.slice((..0).step(-2))        # =>  [5, 3, 1]
@array.slice((...0).step(-2))       # =>  [5, 3, 1]

@array.slice((..0).step(-10))       # =>  [0]
@array.slice((...0).step(-10))      # =>  [0]

## end with positive index
@array.slice((..3).step(-1))        # =>  [5, 4, 3]
@array.slice((...3).step(-1))       # =>  [5, 4, 3]

@array.slice((..3).step(-2))        # =>  [5, 3]
@array.slice((...3).step(-2))       # =>  [5, 3]

@array.slice((..3).step(-10))       # =>  [3]
@array.slice((...3).step(-10))      # =>  [3]

## end with negative index
@array.slice((..-2).step(-1))       # =>  [5, 4]
@array.slice((...-2).step(-1))      # =>  [5, 4]

@array.slice((..-2).step(-2))       # =>  [5]
@array.slice((...-2).step(-2))      # =>  [5]

@array.slice((..-2).step(-10))      # =>  [4]
@array.slice((...-2).step(-10))     # =>  [4]
```

Finally, some examples where the range is "inverted".
Particularly, the results for the ones excluding the end value (`...`) look strange.
But all examples seem weird, but I might not understand the concept of arithmetic sequence in depth.

```ruby
@array = [0, 1, 2, 3, 4, 5]

# start and end with positive index
@array.slice((3..1).step(-1))       # =>  [3, 2, 1]
@array.slice((3...1).step(-1))      # =>  [2, 1]

@array.slice((3..1).step(-2))       # =>  [3, 1]
@array.slice((3...1).step(-2))      # =>  [2]

@array.slice((3..1).step(-10))      # =>  [1]
@array.slice((3...1).step(-10))     # =>  [1]

# start with negative index, end with positive index
@array.slice((-2..1).step(-1))      # =>  [4, 3, 2, 1]
@array.slice((-2...1).step(-1))     # =>  [3, 2, 1]

@array.slice((-2..1).step(-2))      # =>  [4, 2]
@array.slice((-2...1).step(-2))     # =>  [3, 1]

@array.slice((-2..1).step(-10))     # =>  [1]
@array.slice((-2...1).step(-10))    # =>  [1]

# start with positive index, end with negative index
@array.slice((4..-4).step(-1))      # =>  [4, 3, 2]
@array.slice((4...-4).step(-1))     # =>  [3, 2]

@array.slice((4..-4).step(-2))      # =>  [4, 2]
@array.slice((4...-4).step(-2))     # =>  [3]

@array.slice((4..-4).step(-10))     # =>  [2]
@array.slice((4...-4).step(-10))    # =>  [2]

# start with negative index, end with negative index
@array.slice((-2..-4).step(-1))     # =>  [4, 3, 2]
@array.slice((-2...-4).step(-1))    # =>  [3, 2]

@array.slice((-2..-4).step(-2))     # =>  [4, 2]
@array.slice((-2...-4).step(-2))    # =>  [3]

@array.slice((-2..-4).step(-10))    # =>  [2]
@array.slice((-2...-4).step(-10))   # =>  [2]
```



-- 
https://bugs.ruby-lang.org/

       reply	other threads:[~2021-10-08 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 15:38 lxxxvi [this message]
2022-03-30 23:05 ` [ruby-core:108127] [Ruby master Bug#18247] weird results for `Array#slice` or `Array#[]` with argument of type `Enumerator::ArithmeticSequence` jeremyevans0 (Jeremy Evans)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.issue-18247.20211008153838.51932@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).