From: ruby-lang@leipert.io
To: ruby-core@ruby-lang.org
Subject: [ruby-core:102089] [Ruby master Bug#17542] Username and password are not decoded if retrieved from env
Date: Thu, 14 Jan 2021 12:30:22 +0000 (UTC) [thread overview]
Message-ID: <redmine.issue-17542.20210114123021.48179@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-17542.20210114123021.48179@ruby-lang.org
Issue #17542 has been reported by leipert (Lukas Eipert).
----------------------------------------
Bug #17542: Username and password are not decoded if retrieved from env
https://bugs.ruby-lang.org/issues/17542
* Author: leipert (Lukas Eipert)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin18]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
If someone sets an env variable defining a http_proxy (ENV['http_proxy']), containing a
username / password with percent-encoded characters, then the resulting
base64 encoded auth header will be wrong.
For example, suppose a username is `Y\X` and the password is `R%S] ?X`.
Properly URL encoded the proxy url would be:
http://Y%5CX:R%25S%5D%20%3FX@proxy.example:8000
The resulting proxy auth header should be: `WVxYOlIlU10gP1g=`, but the
getters defined by ruby StdLib `URI` return a username `Y%5CX` and
password `R%25S%5D%20%3FX`, resulting in `WSU1Q1g6UiUyNVMlNUQlMjAlM0ZY`.
As a result the proxy will deny the request.
Please note that this is my first contribution to the ruby ecosystem, to
standard lib especially and I am not a ruby developer. I don't
understand ruby's encoding system and the code is not properly
ruby-esque. Sorry for that and a happy and healthy 2021!
---
The description above is taken from: https://github.com/ruby/net-http/pull/5
References:
- https://gitlab.com/gitlab-org/gitlab/-/issues/289836
- https://bugs.ruby-lang.org/projects/ruby-master/repository/trunk/revisions/58461
- https://bugs.ruby-lang.org/issues/12921
--
https://bugs.ruby-lang.org/
next parent reply other threads:[~2021-01-14 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 12:30 ruby-lang [this message]
2021-04-28 11:44 ` [ruby-core:103641] [Ruby master Bug#17542] Username and password are not decoded if retrieved from env nagachika00
2021-05-29 5:21 ` [ruby-core:104094] " nagachika00
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-17542.20210114123021.48179@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).