[ruby-core:100858] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[ruby-core:100858] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[chris]

Issue #17327 has been reported by chrisseaton (Chris Seaton).

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:100859] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[chris]

Issue #17327 has been updated by chrisseaton (Chris Seaton).


https://github.com/ruby/ruby/pull/3768

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-88503

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:100860] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[samuel]

Issue #17327 has been updated by ioquatix (Samuel Williams).


What about a way to bulk add items, and maybe it would be best to have the first argument as an array, e.g. `Queue.new(worklist)`? I think it's more expensive to expand it in CRuby when you write `*worklist`.

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-88504

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:100861] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[chris]

Issue #17327 has been updated by chrisseaton (Chris Seaton).


I'm not worried about `Queue.new(worklist)` or `Queue.new(*worklist)`, so that's fine if more people feel that way. I think the key thing is conciseness in text source code, and also avoiding needing to synchronise while adding each individual item.

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-88505

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:100862] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[samuel]

Issue #17327 has been updated by ioquatix (Samuel Williams).


That all makes sense to me.

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-88506

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:100870] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[jean.boussier]

Issue #17327 has been updated by byroot (Jean Boussier).


I agree that the constructor should take an enumerable rather than variadic arguments, as it would be consistent with `Set.new([1, 2, 3])`, and `Array.new([1, 2, 3])`

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-88517

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:100871] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[ufuk]

Issue #17327 has been updated by ufuk (Ufuk Kayserilioglu).


Agreed with @byroot (actually I was going to note the same, he beat me to it). 

I would also like to note that different from `Set`, for example, the order of items in the supplied parameter matters in the `Queue` case. Even though the expected outcome is for the items to be `push`ed to the `Queue` in given order, it might still be a good idea to explicitly call that out in the method documentation.

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-88518

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:101339] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[chris]

Issue #17327 has been updated by chrisseaton (Chris Seaton).


I updated to take a single array rather than a variable number of arguments.

I had two choices for how to do this - `Set` takes an `Enumerable`, using `each` to access items, and `Array` takes another `Array`, using `#to_ary` if needed.

I went with the same as what `Array` does, because both `Array` and `Queue` are core libraries, where `Set` is a standard library.

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-89039

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:102050] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[matz]

Issue #17327 has been updated by matz (Yukihiro Matsumoto).


I accept the idea. Take `Enumerable` as initial values.

Matz.


----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-89906

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/

[ruby-core:102290] [Ruby master Feature#17327] The Queue constructor should take an initial set of items

[ko1]

Issue #17327 has been updated by ko1 (Koichi Sasada).

Assignee set to ko1 (Koichi Sasada)

----------------------------------------
Feature #17327: The Queue constructor should take an initial set of items
https://bugs.ruby-lang.org/issues/17327#change-90145

* Author: chrisseaton (Chris Seaton)
* Status: Open
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
----------------------------------------
I often create a `Queue` and then process it with a set of concurrent workers in threads. I end up writing:

```ruby
q = Queue.new
worklist.each do |work|
  q.push work
end
```

I'd rather be able to write

```ruby
q = Queue.new(*worklist)
```



-- 
https://bugs.ruby-lang.org/