From: Greg.mpls@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:96818] [Ruby master Misc#16507] =~ vs include? or match?
Date: Sun, 12 Jan 2020 23:27:07 +0000 (UTC) [thread overview]
Message-ID: <redmine.issue-16507.20200112232707.259e04ccb584a0c3@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-16507.20200112232707@ruby-lang.org
Issue #16507 has been reported by MSP-Greg (Greg L).
----------------------------------------
Misc #16507: =~ vs include? or match?
https://bugs.ruby-lang.org/issues/16507
* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee:
----------------------------------------
While working on getting the mswin build working on Actions, I thought adding mswin? and ci? methods to Minitest::Unit::Guard in tool/lib/minitest/unit.rb would be helpful.
Currently some tests are failing that are guarded/skipped based on ENV['APPVEYOR']. For ci?, I'd combine Travis, AppVeyor, & Actions.
There are quite a few instances where =~ is used for a boolean return. Would it be considered appropriate to replace those calls with include? or match?
--
https://bugs.ruby-lang.org/
parent reply other threads:[~2020-01-12 23:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <redmine.issue-16507.20200112232707@ruby-lang.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.issue-16507.20200112232707.259e04ccb584a0c3@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).