ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:81613] Re: [Ruby trunk Bug#13632] Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread.
Date: Wed, 7 Jun 2017 20:05:26 +0000	[thread overview]
Message-ID: <20170607200525.GA4079@dcvr> (raw)
In-Reply-To: <20170606002051.GA1307@dcvr>

Eric Wong <normalperson@yhbt.net> wrote:
> sir.nickolas@gmail.com wrote:
> > https://bugs.ruby-lang.org/issues/13632
> 
> r59020 should fix it trivially in trunk.

Make that r59028 :x  r59020 interacted badly with r57422

> Backporting to <= 2.4 is only a little different due to the
> data structure change:

r59028 backporting is more difficult.

Below are links to backported patches from trunk to fix [Bug #13632] for
Ruby 2.4 maintenance branches and earlier.   I mainly wanted to
backport r59028, but that depends on r58812 (originally intended
as a pure performance optimization).

I'd rather not change r59028 to something unrecognizable from
what is in trunk for backporting, as that might negatively
impact future backports.

r58812: speed up IO#close with many threads
   https://80x24.org/spew/20170607195901.18958-2-e@80x24.org/raw
r59028: IO#close: do not enqueue redundant interrupts (take #2)
   https://80x24.org/spew/20170607195901.18958-3-e@80x24.org/raw

 test/ruby/test_io.rb | 22 ++++++++++++++++++++++
 thread.c             | 33 ++++++++++++++++++++++++---------
 vm.c                 |  1 -
 vm_core.h            |  4 ++--
 4 files changed, 48 insertions(+), 12 deletions(-)

  reply	other threads:[~2017-06-07 20:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-13632.20170605161653@ruby-lang.org>
2017-06-05 16:16 ` [ruby-core:81581] [Ruby trunk Bug#13632] Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread sir.nickolas
2017-06-05 21:51   ` [ruby-core:81584] " Eric Wong
2017-06-06  0:20   ` [ruby-core:81585] " Eric Wong
2017-06-07 20:05     ` Eric Wong [this message]
2017-07-08  2:21 ` [ruby-core:81966] " nagachika00
2017-07-17  4:23 ` [ruby-core:82085] " sir.nickolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607200525.GA4079@dcvr \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).