From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 239CC1FAEB for ; Wed, 7 Jun 2017 20:05:33 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B1F2512073E; Thu, 8 Jun 2017 05:05:30 +0900 (JST) Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by neon.ruby-lang.org (Postfix) with ESMTPS id BDFE1120736 for ; Thu, 8 Jun 2017 05:05:27 +0900 (JST) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 06D1F1FAEB; Wed, 7 Jun 2017 20:05:26 +0000 (UTC) Date: Wed, 7 Jun 2017 20:05:26 +0000 From: Eric Wong To: ruby-core@ruby-lang.org Message-ID: <20170607200525.GA4079@dcvr> References: <20170606002051.GA1307@dcvr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170606002051.GA1307@dcvr> X-ML-Name: ruby-core X-Mail-Count: 81613 Subject: [ruby-core:81613] Re: [Ruby trunk Bug#13632] Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread. X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Eric Wong wrote: > sir.nickolas@gmail.com wrote: > > https://bugs.ruby-lang.org/issues/13632 > > r59020 should fix it trivially in trunk. Make that r59028 :x r59020 interacted badly with r57422 > Backporting to <= 2.4 is only a little different due to the > data structure change: r59028 backporting is more difficult. Below are links to backported patches from trunk to fix [Bug #13632] for Ruby 2.4 maintenance branches and earlier. I mainly wanted to backport r59028, but that depends on r58812 (originally intended as a pure performance optimization). I'd rather not change r59028 to something unrecognizable from what is in trunk for backporting, as that might negatively impact future backports. r58812: speed up IO#close with many threads https://80x24.org/spew/20170607195901.18958-2-e@80x24.org/raw r59028: IO#close: do not enqueue redundant interrupts (take #2) https://80x24.org/spew/20170607195901.18958-3-e@80x24.org/raw test/ruby/test_io.rb | 22 ++++++++++++++++++++++ thread.c | 33 ++++++++++++++++++++++++--------- vm.c | 1 - vm_core.h | 4 ++-- 4 files changed, 48 insertions(+), 12 deletions(-)