From: Eric Wong <normalperson@yhbt.net>
To: ruby-core@ruby-lang.org
Subject: [ruby-core:71957] Re: [Ruby trunk - Bug #11759] URI breaks with frozen strings
Date: Tue, 8 Dec 2015 21:35:19 +0000 [thread overview]
Message-ID: <20151208213519.GB10047@dcvr.yhbt.net> (raw)
In-Reply-To: <redmine.journal-55316.20151207155928.e8c2af2a25845d38@ruby-lang.org>
colin@invoca.com wrote:
> > I prefer String.new() to "".dup because the former describes intention (of creating a buffer).
>
> Ok. I've attached a rev3 patch that uses `String.new` instead of `''.dup`.
Thanks. Committed as r52981
> > In fact, my best choice is introducing String#+ that returns a mutable copy of a string.
>
> How would that be different from the current binary string operator `String#+` that does string concatenation?
It actually calls the "+@" method as implemented in r52917 / [Feature #11782]
But according to [ruby-core:71924], maybe it's not a good idea...
prev parent reply other threads:[~2015-12-08 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-11759.20151202000114@ruby-lang.org>
2015-12-02 0:01 ` [ruby-core:71785] [Ruby trunk - Bug #11759] [Open] URI breaks with frozen strings mperham
2015-12-02 1:18 ` [ruby-core:71786] [Ruby trunk - Bug #11759] " me
2015-12-02 1:30 ` [ruby-core:71787] " me
2015-12-02 1:47 ` [ruby-core:71788] " Eric Wong
2015-12-02 3:56 ` [ruby-core:71790] " me
2015-12-02 4:10 ` [ruby-core:71791] " akr
2015-12-02 7:11 ` [ruby-core:71797] " colin
2015-12-02 21:36 ` [ruby-core:71804] " Eric Wong
2015-12-03 5:20 ` [ruby-core:71812] " colin
2015-12-03 23:41 ` [ruby-core:71820] " Eric Wong
2015-12-05 16:20 ` [ruby-core:71846] " colin
2015-12-07 7:19 ` [ruby-core:71879] " matz
2015-12-07 15:59 ` [ruby-core:71910] " colin
2015-12-08 21:35 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208213519.GB10047@dcvr.yhbt.net \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).