ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Ruby developers <ruby-core@ruby-lang.org>
Subject: [ruby-core:71804] Re: [Ruby trunk - Bug #11759] URI breaks with frozen strings
Date: Wed, 2 Dec 2015 21:36:31 +0000	[thread overview]
Message-ID: <20151202213631.GA27439@dcvr.yhbt.net> (raw)
In-Reply-To: <redmine.journal-55205.20151202071123.143c24a6219a48be@ruby-lang.org>

colin@invoca.com wrote:
> Isn't it sufficient to initialize the string buffer with String.new?

Yes, but I prefer to avoid String.new because the constant lookup
requires an inline cache lookup + storage entry in the iseq.

Here's their respective disassembly code:

''.freeze.dup
== disasm: #<ISeq:<compiled>@<compiled>>================================
0000 trace            1                                               (   1)
0002 opt_str_freeze   ""
0004 opt_send_without_block <callinfo!mid:dup, argc:0, ARGS_SIMPLE>, <callcache>
0007 leave


String.new
== disasm: #<ISeq:<compiled>@<compiled>>================================
0000 trace            1                                               (   1)
0002 getinlinecache   9, <is:0>
0005 getconstant      :String
0007 setinlinecache   <is:0>
0009 opt_send_without_block <callinfo!mid:new, argc:0, ARGS_SIMPLE>, <callcache>
0012 leave

But maybe String.new is slightly faster; but I normally
prefer smaller code unless something is called in a tight loop.

  reply	other threads:[~2015-12-02 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-11759.20151202000114@ruby-lang.org>
2015-12-02  0:01 ` [ruby-core:71785] [Ruby trunk - Bug #11759] [Open] URI breaks with frozen strings mperham
2015-12-02  1:18 ` [ruby-core:71786] [Ruby trunk - Bug #11759] " me
2015-12-02  1:30 ` [ruby-core:71787] " me
2015-12-02  1:47   ` [ruby-core:71788] " Eric Wong
2015-12-02  3:56 ` [ruby-core:71790] " me
2015-12-02  4:10 ` [ruby-core:71791] " akr
2015-12-02  7:11 ` [ruby-core:71797] " colin
2015-12-02 21:36   ` Eric Wong [this message]
2015-12-03  5:20 ` [ruby-core:71812] " colin
2015-12-03 23:41   ` [ruby-core:71820] " Eric Wong
2015-12-05 16:20 ` [ruby-core:71846] " colin
2015-12-07  7:19 ` [ruby-core:71879] " matz
2015-12-07 15:59 ` [ruby-core:71910] " colin
2015-12-08 21:35   ` [ruby-core:71957] " Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202213631.GA27439@dcvr.yhbt.net \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).