rack-devel archive mirror (unofficial) https://groups.google.com/group/rack-devel
 help / color / mirror / Atom feed
From: Ryan Tomayko <r@tomayko.com>
To: rack-devel@googlegroups.com
Subject: Re: [Patch] Deleting cookies with the same name from multiple domains
Date: Fri, 15 Jan 2010 06:52:29 -0800	[thread overview]
Message-ID: <f732822d1001150652sa473775mca8701d90bb4b738@mail.gmail.com> (raw)
In-Reply-To: <d3965c3e1001072201j2ccea0dby46b4fa1a60c01a6f@mail.gmail.com>

On Thu, Jan 7, 2010 at 10:01 PM, Zach Brock <zbrock@gmail.com> wrote:
> This is a fix to an issue I ran into when dealing with a single sign on
> system. Cookies should be unique per request by name and domain, but Rack
> currently only treats them as unique by name. This commit basically makes it
> possible to delete cookie "foo" on both www.example.com and .example.com.
> -Zach Brock

I've had reports of a bug that disallows same-named cookies to be set
for different domains. It looks like your patch addresses this as
well. Can you confirm?

Thanks,
Ryan

      reply	other threads:[~2010-01-15 14:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08  6:01 [Patch] Deleting cookies with the same name from multiple domains Zach Brock
2010-01-15 14:52 ` Ryan Tomayko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://groups.google.com/group/rack-devel

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f732822d1001150652sa473775mca8701d90bb4b738@mail.gmail.com \
    --to=rack-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).