From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.140.141.15 with SMTP id o15cs252089rvd; Fri, 15 Jan 2010 06:52:36 -0800 (PST) Received: from mr.google.com ([10.224.68.12]) by 10.224.68.12 with SMTP id t12mr805916qai.12.1263567155072 (num_hops = 1); Fri, 15 Jan 2010 06:52:35 -0800 (PST) Received: by 10.224.68.12 with SMTP id t12mr44734qai.12.1263567153391; Fri, 15 Jan 2010 06:52:33 -0800 (PST) X-BeenThere: rack-devel@googlegroups.com Received: by 10.224.87.16 with SMTP id u16ls751063qal.5.p; Fri, 15 Jan 2010 06:52:31 -0800 (PST) Received: by 10.224.123.206 with SMTP id q14mr226764qar.23.1263567150756; Fri, 15 Jan 2010 06:52:30 -0800 (PST) Received: by 10.224.123.206 with SMTP id q14mr226762qar.23.1263567150350; Fri, 15 Jan 2010 06:52:30 -0800 (PST) Return-Path: Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.27]) by gmr-mx.google.com with ESMTP id 25si555371qyk.7.2010.01.15.06.52.29; Fri, 15 Jan 2010 06:52:29 -0800 (PST) Received-SPF: pass (google.com: domain of rtomayko@gmail.com designates 74.125.92.27 as permitted sender) client-ip=74.125.92.27; Received: by qw-out-2122.google.com with SMTP id 5so162431qwd.1 for ; Fri, 15 Jan 2010 06:52:29 -0800 (PST) MIME-Version: 1.0 Sender: rack-devel@googlegroups.com Received: by 10.224.123.213 with SMTP id q21mr2231945qar.225.1263567149185; Fri, 15 Jan 2010 06:52:29 -0800 (PST) In-Reply-To: References: Date: Fri, 15 Jan 2010 06:52:29 -0800 Message-ID: Subject: Re: [Patch] Deleting cookies with the same name from multiple domains From: Ryan Tomayko To: rack-devel@googlegroups.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of rtomayko@gmail.com designates 74.125.92.27 as permitted sender) smtp.mail=rtomayko@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: r@tomayko.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rack-devel/t/eaf3e5ccebf0caaf X-Message-Url: http://groups.google.com/group/rack-devel/msg/f12e5768c24896af List-Unsubscribe: , List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Jan 7, 2010 at 10:01 PM, Zach Brock wrote: > This is a fix to an issue I ran into when dealing with a single sign on > system. Cookies should be unique per request by name and domain, but Rack > currently only treats them as unique by name. This commit basically makes= it > possible to delete cookie "foo" on both=C2=A0www.example.com=C2=A0and .ex= ample.com. > -Zach Brock I've had reports of a bug that disallows same-named cookies to be set for different domains. It looks like your patch addresses this as well. Can you confirm? Thanks, Ryan