Re: Rack 1.0.1 maintenance release

[Joshua Peek <josh@joshpeek.com>]

Please!

On Aug 9, 2:50 am, Ryan Tomayko <r...@tomayko.com> wrote:
> On Tue, Aug 4, 2009 at 7:22 PM, Joshua Peek<j...@joshpeek.com> wrote:
>
> > On Mon, Aug 3, 2009 at 5:25 PM, Christian
> > Neukirchen<chneukirc...@gmail.com> wrote:
> >>> I'd like to do a 1.0.1 maintenance soon of the rack-1.0 branch. Please
> >>> test your apps and frameworks on that branch. It should be a fully
> >>> compatible bug fix release.
>
> >> This is a good idea.  When you consider it ready, I can write an
> >> announcement and do a formal release on Rubyforge and my servers.
>
> > Rails 2.3 is all systems go w/ rack 1.0.1.
>
> > Should wait on Ryan to test w/ Sinatra.
>
> Sorry. I'm way behind on ML/lighthouse duties.
>
> Sinatra looks good under the rack-1.0 branch. +1 for release.
>
> The Sinatra test suite fails like crazy under 1.9 due to this
> rack.input / external encoding Rack::Lint check:
>
> http://github.com/rack/rack/commit/851782648fbbb141b1b56b73d8efc99efc...
>
> The Sinatra test suite puts Rack::Lint in the middleware pipeline for
> every test, though. I don't think that's a common practice. It passes
> 100% when I remove that check. The issue seems to be with the way
> Rack::MockRequest wraps the :input string in an StringIO without any
> encoding work. Or, maybe we should be setting the encoding on the
> input string before passing it in. I should be able to work around
> this in Sinatra somehow.
>
> Thanks,
> Ryan