From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.86.99.8 with SMTP id w8cs79787fgb; Mon, 5 Oct 2009 10:16:08 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.220.4.30 as permitted sender) client-ip=10.220.4.30; Authentication-Results: mr.google.com; spf=pass (google.com: domain of grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com designates 10.220.4.30 as permitted sender) smtp.mail=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com; dkim=pass header.i=grbounce-ceibQwUAAAB4YPBqaDIjI2bFOCxyyh3G=chneukirchen=gmail.com@googlegroups.com Received: from mr.google.com ([10.220.4.30]) by 10.220.4.30 with SMTP id 30mr141032vcp.17.1254762965456 (num_hops = 1); Mon, 05 Oct 2009 10:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :mime-version:received:date:in-reply-to:x-ip:references:user-agent :x-http-useragent:message-id:subject:from:to:content-type :content-transfer-encoding:reply-to:sender:precedence:x-google-loop :mailing-list:list-id:list-post:list-help:list-unsubscribe :x-beenthere-env:x-beenthere; bh=o30N7EuQXZwODZSO0Rj2ZxcO5K4TjDWUN4SOGO14Sa4=; b=TO/jmmzhByvcPJgE9i/+ZLhZdkhJtqfxIokWhKHNtNh/4/rYmiKUk+5eG09ErIt4PE N/W2szoxYaW2YGeQmgilmTLY5VSAH+b94DPDOLI3eQh8znWo7cHejN3K1aEoBY5/ypHZ /8lKJmgMq22mEjStOE8D9vxWlV+7lySXqqq0Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:mime-version:date:in-reply-to:x-ip :references:user-agent:x-http-useragent:message-id:subject:from:to :content-type:content-transfer-encoding:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; b=jTqPJM0Ri2hnv4XxfQ032Zp1CF7Uhc49AryPCZcuNBux+vjeVkVU2OevO64KeP/Mug RUwTUsP01pVg74rKqhbYc+8ump2B206p3t9MQ42ditmaRi793ZmQsfKQt76RuKwNw69k hYF0fEKIm6svNOUx/Ulam6din81ewr9BBDM5k= Received: by 10.220.4.30 with SMTP id 30mr10853vcp.17.1254762959872; Mon, 05 Oct 2009 10:15:59 -0700 (PDT) Received: by 10.176.133.2 with SMTP id g2gr1674yqd.0; Mon, 05 Oct 2009 10:15:50 -0700 (PDT) X-Sender: josh@joshpeek.com X-Apparently-To: rack-devel@googlegroups.com MIME-Version: 1.0 Received: by 10.150.112.3 with SMTP id k3mr754769ybc.25.1254762948129; Mon, 05 Oct 2009 10:15:48 -0700 (PDT) Date: Mon, 5 Oct 2009 10:15:48 -0700 (PDT) In-Reply-To: X-IP: 98.226.9.61 References: <1c5622660908041922l2ae9490cp98c81d63f83318d5@mail.gmail.com> User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_1; en-us) AppleWebKit/531.9 (KHTML, like Gecko) Version/4.0.3 Safari/531.9,gzip(gfe),gzip(gfe) Message-ID: Subject: Re: Rack 1.0.1 maintenance release From: Joshua Peek To: Rack Development Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Reply-To: rack-devel@googlegroups.com Sender: rack-devel@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rack-devel@googlegroups.com; contact rack-devel+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rack-devel@googlegroups.com X-BeenThere: rack-devel@googlegroups.com Please! On Aug 9, 2:50=A0am, Ryan Tomayko wrote: > On Tue, Aug 4, 2009 at 7:22 PM, Joshua Peek wrote: > > > On Mon, Aug 3, 2009 at 5:25 PM, Christian > > Neukirchen wrote: > >>> I'd like to do a 1.0.1 maintenance soon of the rack-1.0 branch. Pleas= e > >>> test your apps and frameworks on that branch. It should be a fully > >>> compatible bug fix release. > > >> This is a good idea. =A0When you consider it ready, I can write an > >> announcement and do a formal release on Rubyforge and my servers. > > > Rails 2.3 is all systems go w/ rack 1.0.1. > > > Should wait on Ryan to test w/ Sinatra. > > Sorry. I'm way behind on ML/lighthouse duties. > > Sinatra looks good under the rack-1.0 branch. +1 for release. > > The Sinatra test suite fails like crazy under 1.9 due to this > rack.input / external encoding Rack::Lint check: > > http://github.com/rack/rack/commit/851782648fbbb141b1b56b73d8efc99efc... > > The Sinatra test suite puts Rack::Lint in the middleware pipeline for > every test, though. I don't think that's a common practice. It passes > 100% when I remove that check. The issue seems to be with the way > Rack::MockRequest wraps the :input string in an StringIO without any > encoding work. Or, maybe we should be setting the encoding on the > input string before passing it in. I should be able to work around > this in Sinatra somehow. > > Thanks, > Ryan