Re: [PATCH] conditionalget: avoid const lookup in case/when

[richard schneeman <richard.schneeman@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]

Thank you Eric indeed! It took me a little while to figure out, so i 
thought I would mention, you can reference git commits for ruby/ruby by 
running:

```
$ git log --grep "trunk@44058"
```

That first SVN commit is
 
*https://github.com/ruby/ruby/commit/779ae78995977305aa5aec9cb5b562dcf54c22e7*

The second commit is:
*https://github.com/ruby/ruby/commit/58f800a278b8b70463f4afdbb23a918d8ab441ff*

Eric's proposal: *https://bugs.ruby-lang.org/issues/9425*


I agree that the patch should one day be unnecessary, In the mean time i'm 
happy to get faster execution while we wait. I was talking with Koichi 
about how or if we might optimize so we could write "normal" ruby code and 
still have it run as memory efficient and fast as using constants. He 
showed me that this string de-duplication feature was in 2.2, though I was 
having a hard time finding the commits. Thank you Eric for listing them.

In my research it was also pointed out that string de-duplication was added 
to JVM-8 *http://java-performance.info/java-string-deduplication/*. I think 
it's great that Ruby has already started to make string de-duplication 
optimizations.

Thanks for the perf help and again for the links!

-- 

--- 
You received this message because you are subscribed to the Google Groups "Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: Type: text/html, Size: 2961 bytes --]