From mboxrd@z Thu Jan 1 00:00:00 1970 Delivered-To: chneukirchen@gmail.com Received: by 10.25.37.80 with SMTP id l77csp241980lfl; Mon, 6 Oct 2014 15:34:36 -0700 (PDT) Return-Path: Received-SPF: pass (google.com: domain of rack-devel+bncBDY4TNV6V4PRB65RZSQQKGQEDEBBU6Q@googlegroups.com designates 10.140.97.117 as permitted sender) client-ip=10.140.97.117 Authentication-Results: mr.google.com; spf=pass (google.com: domain of rack-devel+bncBDY4TNV6V4PRB65RZSQQKGQEDEBBU6Q@googlegroups.com designates 10.140.97.117 as permitted sender) smtp.mail=rack-devel+bncBDY4TNV6V4PRB65RZSQQKGQEDEBBU6Q@googlegroups.com; dkim=pass header.i=@googlegroups.com X-Received: from mr.google.com ([10.140.97.117]) by 10.140.97.117 with SMTP id l108mr2761692qge.3.1412634876828 (num_hops = 1); Mon, 06 Oct 2014 15:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:message-id:in-reply-to:references:subject:mime-version :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=CecmU72+zPHjE7GR0+zik4v7S7Ot1zG3EZY8lXkRvRI=; b=po5qcOkDgmW1VXy7wLr2K3BJO3KpNZ2dfB7s9nzFS4RY22VTBvHMFdi4oALlRiJyuc CcbdgjgIiFrdKmzazMFYxvnd9XvkZr+0k8meJx7JMYbfS6CBXKqcibFuMcg2IOuA9fBm hrZi1KVsnBTWbpL2+MXMAXPb6XxkZoaEQ9wxVKV1pjDFZtso+qvbSfs0PgExBEDGYEXm ps60rAtiNGC5n2rGX/SRIIU7PrYlr39G/ow/pO5a9eXqb32wVE9CAYCnYchyWLorRaAc zodJVNgXV4LBlMdTgVCts3q3wYgBQ/BNqXlG0lGxHw3PVYkwwKcuNnBwjfp2i8qWPuM7 yZ+w== X-Received: by 10.140.97.117 with SMTP id l108mr309245qge.3.1412634876195; Mon, 06 Oct 2014 15:34:36 -0700 (PDT) X-BeenThere: rack-devel@googlegroups.com Received: by 10.140.94.211 with SMTP id g77ls2585451qge.77.gmail; Mon, 06 Oct 2014 15:34:35 -0700 (PDT) X-Received: by 10.236.229.195 with SMTP id h63mr12728349yhq.40.1412634875591; Mon, 06 Oct 2014 15:34:35 -0700 (PDT) Received: by 10.50.144.195 with SMTP id so3msigb; Mon, 6 Oct 2014 13:00:19 -0700 (PDT) X-Received: by 10.182.108.166 with SMTP id hl6mr16878obb.26.1412625619297; Mon, 06 Oct 2014 13:00:19 -0700 (PDT) Date: Mon, 6 Oct 2014 13:00:17 -0700 (PDT) From: richard schneeman To: rack-devel@googlegroups.com Message-Id: In-Reply-To: References: <20141003200836.GA4664@dcvr.yhbt.net> <20141005081525.GA8997@dcvr.yhbt.net> Subject: Re: [PATCH] conditionalget: avoid const lookup in case/when MIME-Version: 1.0 X-Original-Sender: richard.schneeman@gmail.com Reply-To: rack-devel@googlegroups.com Precedence: list Mailing-list: list rack-devel@googlegroups.com; contact rack-devel+owners@googlegroups.com List-ID: X-Google-Group-Id: 486215384060 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Content-Type: multipart/alternative; boundary="----=_Part_10264_497351097.1412625618130" ------=_Part_10264_497351097.1412625618130 Content-Type: text/plain; charset=UTF-8 Thank you Eric indeed! It took me a little while to figure out, so i thought I would mention, you can reference git commits for ruby/ruby by running: ``` $ git log --grep "trunk@44058" ``` That first SVN commit is *https://github.com/ruby/ruby/commit/779ae78995977305aa5aec9cb5b562dcf54c22e7* The second commit is: *https://github.com/ruby/ruby/commit/58f800a278b8b70463f4afdbb23a918d8ab441ff* Eric's proposal: *https://bugs.ruby-lang.org/issues/9425* I agree that the patch should one day be unnecessary, In the mean time i'm happy to get faster execution while we wait. I was talking with Koichi about how or if we might optimize so we could write "normal" ruby code and still have it run as memory efficient and fast as using constants. He showed me that this string de-duplication feature was in 2.2, though I was having a hard time finding the commits. Thank you Eric for listing them. In my research it was also pointed out that string de-duplication was added to JVM-8 *http://java-performance.info/java-string-deduplication/*. I think it's great that Ruby has already started to make string de-duplication optimizations. Thanks for the perf help and again for the links! -- --- You received this message because you are subscribed to the Google Groups "Rack Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to rack-devel+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ------=_Part_10264_497351097.1412625618130 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thank you Eric indeed!= It took me a little while to figure out, so i thought I would mention, you= can reference git commits for ruby/ruby by running:

```
$ git log --grep "trunk@44058" ```
That first SVN commit is
 https://github.com/ruby/ruby/commit/77= 9ae78995977305aa5aec9cb5b562dcf54c22e7

The second commit is:
https://gith= ub.com/ruby/ruby/commit/58f800a278b8b70463f4afdbb23a918d8ab441ff=

Eric's proposal: https://bugs.ruby-lang.org/= issues/9425


I agree that the patch should one day b= e unnecessary, In the mean time i'm happy to get faster execution while we = wait. I was talking with Koichi about how or if we might optimize so we cou= ld write "normal" ruby code and still have it run as memory efficient and f= ast as using constants. He showed me that this string de-duplication featur= e was in 2.2, though I was having a hard time finding the commits. Thank yo= u Eric for listing them.

In my research it was also pointed out = that string de-duplication was added to JVM-8 http://java-performance.info/java-= string-deduplication/. I thi= nk it's great that Ruby has already started to make string de-duplication o= ptimizations.

Thanks for the perf help and again for the links!

--

---
You received this message because you are subscribed to the Google Groups &= quot;Rack Development" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to rack-dev= el+unsubscribe@googlegroups.com.
For more options, visit http= s://groups.google.com/d/optout.
------=_Part_10264_497351097.1412625618130--