Getting started submitting a patch

Getting started submitting a patch

[brycemcd]

[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]

I'm trying to get going with submitting a pull request but can't get the 
tests to run.

My environment:
ruby 1.9.3
rubygems 1.8.15

gems:
bacon (1.1.0)
bundler (1.0.22)
test-spec (0.10.0)
test-unit (2.4.7)
ZenTest (4.6.2)

Before I jump in too far, I want to make sure the test suite runs 
correctly. I run `rake test` , `rake spec`, `rake fulltest` and `specrb 
-Ilib:test -a -w` and all fail with the following output:

/usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/gems/test-spec-0.10.0/lib/test/spec.rb:12:in 
`<class:AutoRunner>': uninitialized constant 
Test::Unit::AutoRunner::RUNNERS (NameError)
from 
/usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/gems/test-spec-0.10.0/lib/test/spec.rb:11:in 
`<top (required)>'
from 
/usr/local/rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in 
`require'
from 
/usr/local/rvm/rubies/ruby-1.9.3-p0/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in 
`require'
from 
/usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/gems/test-spec-0.10.0/bin/specrb:101:in 
`<top (required)>'
from /usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/bin/specrb:19:in `load'
from /usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/bin/specrb:19:in 
`<main>'

Any help to get started would be appreciated. I'll be happy to submit 
another patch to the README with whatever feedback I get.

[-- Attachment #2: Type: text/html, Size: 1990 bytes --]

Re: Getting started submitting a patch

[Eric Wong]

brycemcd <brycebrycebaby@gmail.com> wrote:
> ruby 1.9.3

> test-unit (2.4.7)

> /usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/gems/test-spec-0.10.0/lib/test/spec.rb:12:in 
> `<class:AutoRunner>': uninitialized constant 
> Test::Unit::AutoRunner::RUNNERS (NameError)

It could be a conflict with the test-unit (minitest wrapper) that's
already bundled with Ruby 1.9.3.  Does uninstalling test-unit 2.4.7
help?

Re: Getting started submitting a patch

[James Tucker]

On Mar 5, 2012, at 12:34 PM, Eric Wong wrote:

> brycemcd <brycebrycebaby@gmail.com> wrote:
>> ruby 1.9.3
> 
>> test-unit (2.4.7)
> 
>> /usr/local/rvm/gems/ruby-1.9.3-p0@rack-contrib/gems/test-spec-0.10.0/lib/test/spec.rb:12:in 
>> `<class:AutoRunner>': uninitialized constant 
>> Test::Unit::AutoRunner::RUNNERS (NameError)
> 
> It could be a conflict with the test-unit (minitest wrapper) that's
> already bundled with Ruby 1.9.3.  Does uninstalling test-unit 2.4.7
> help?


Correct, there is a conflict. Pretending to "update" test unit in ruby was quite the mistake.

We need to move rack-contrib over to bacon, test-spec is basically deprecated and largely unsupported these days.