diff options
Diffstat (limited to 'lib/PublicInbox/Tmpfile.pm')
| -rw-r--r-- | lib/PublicInbox/Tmpfile.pm | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/lib/PublicInbox/Tmpfile.pm b/lib/PublicInbox/Tmpfile.pm index 25bb3a52..72dd9d24 100644 --- a/lib/PublicInbox/Tmpfile.pm +++ b/lib/PublicInbox/Tmpfile.pm @@ -1,9 +1,9 @@ -# Copyright (C) 2019-2020 all contributors <meta@public-inbox.org> +# Copyright (C) all contributors <meta@public-inbox.org> # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt> package PublicInbox::Tmpfile; -use strict; -use warnings; -use base qw(Exporter); +use v5.12; +use parent qw(Exporter); +use autodie qw(unlink); our @EXPORT = qw(tmpfile); use Fcntl qw(:DEFAULT); use Errno qw(EEXIST); @@ -13,12 +13,15 @@ use File::Spec; # unlinked filename which makes sense when viewed with lsof # (at least on Linux) # And if we ever stop caring to have debuggable filenames, O_TMPFILE :) +# +# This is also for Perl <5.32 which lacks: open(..., '+>>', undef) +# <https://rt.perl.org/Ticket/Display.html?id=134221> sub tmpfile ($;$$) { my ($id, $sock, $append) = @_; if (defined $sock) { # add the socket inode number so we can figure out which # socket it belongs to - my @st = stat($sock); + my @st = stat($sock) or die "stat($sock): $!"; $id .= '-ino:'.$st[1]; } $id =~ tr!/!^!; @@ -28,7 +31,7 @@ sub tmpfile ($;$$) { do { my $fn = File::Spec->tmpdir . "/$id-".time.'-'.rand; if (sysopen(my $fh, $fn, $fl, 0600)) { # likely - unlink($fn) or warn "unlink($fn): $!"; # FS broken + unlink($fn); return $fh; # success } } while ($! == EEXIST); |