about summary refs log tree commit homepage
path: root/xt
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2020-09-09 06:26:10 +0000
committerEric Wong <e@80x24.org>2020-09-10 19:45:18 +0000
commit934fea5e3b3c4c1ef0cef29477941ebfc44ff7e0 (patch)
tree6217ad86260050f1e2a271536d1233633fc915fc /xt
parent38226be5fd4c24885658e00d4ce87ccee663063d (diff)
downloadpublic-inbox-934fea5e3b3c4c1ef0cef29477941ebfc44ff7e0.tar.gz
use "\&" where possible when referring to subroutines
"*foo" is ambiguous in that it may refer to a bareword file handle;
so we'll use it where we can without triggering warnings.

PublicInbox::TestCommon::run_script_exit required dropping the
prototype, however.  We'll also future-proof by dropping "use
warnings" in Cgit.pm and use the less-ambiguous "//=" in Inbox.pm
while we're in the area.
Diffstat (limited to 'xt')
-rw-r--r--xt/msgtime_cmp.t2
1 files changed, 1 insertions, 1 deletions
diff --git a/xt/msgtime_cmp.t b/xt/msgtime_cmp.t
index 0ce3c042..aa96be4d 100644
--- a/xt/msgtime_cmp.t
+++ b/xt/msgtime_cmp.t
@@ -62,7 +62,7 @@ my $fh = $git->popen(@cat);
 while (<$fh>) {
         my ($oid, $type) = split / /;
         next if $type ne 'blob';
-        $git->cat_async($oid, *compare);
+        $git->cat_async($oid, \&compare);
 }
 $git->cat_async_wait;
 ok(1);