search: make xap_terms easier-to-use and use it more

This allows us to simplify callers throughout, and exceptions are
can no longer be silently hidden.  MiscSearch now uses xap_terms
for looking up eidx_key terms for a code reduction.

We also simplify LeiStore->_msg_kw for runtime use by moving the
MsetIterator handling into t/lei_store.t test case.

1 files changed, 2 insertions, 1 deletions

diff --git a/t/lei_store.t b/t/lei_store.t
index db94f6da..73b5c74d 100644
--- a/t/lei_store.t
+++ b/t/lei_store.t
@@ -31,7 +31,8 @@ $sto->done;
         is($mset->size, 1, 'search works');
         is_deeply($es->mset_to_artnums($mset), [ $msgs->[0]->{num} ],
                 'mset_to_artnums');
-        my @kw = $es->msg_keywords(($mset->items)[0]);
+        my $mi = ($mset->items)[0];
+        my @kw = PublicInbox::Search::xap_terms('K', $mi->get_document);
         is_deeply(\@kw, [], 'no flags');
 }