about summary refs log tree commit homepage
path: root/t/filter_base.t
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-04-25 05:52:22 +0000
committerEric Wong <e@yhbt.net>2020-04-26 07:03:14 +0000
commite39585ee2bdcbeaab7b6bd33b3568021042d0879 (patch)
treeb130b0ce73d8ce9624424c4de6999481ab96439d /t/filter_base.t
parent5d8dbb4aca5afcc6b98a4d951f03003fb7eaf356 (diff)
downloadpublic-inbox-e39585ee2bdcbeaab7b6bd33b3568021042d0879.tar.gz
tests: remove Email::MIME->create use entirely
Replace them with .eml files generated with the help of
Email::MIME, but without some extraneous and unnecessary
headers, and strip mime_load down to just loading files.

This will give us more freedom to experiment with other mail
libraries which may be more correct, better maintained, use
less memory and/or be faster than Email::MIME.
Diffstat (limited to 't/filter_base.t')
-rw-r--r--t/filter_base.t53
1 files changed, 2 insertions, 51 deletions
diff --git a/t/filter_base.t b/t/filter_base.t
index 7919dd65..bbd64189 100644
--- a/t/filter_base.t
+++ b/t/filter_base.t
@@ -21,62 +21,13 @@ use_ok 'PublicInbox::Filter::Base';
 
 {
         my $f = PublicInbox::Filter::Base->new;
-        my $email = mime_load 't/filter_base-xhtml.eml', sub {
-        my $html_body = "<html><body>hi</body></html>";
-        my $parts = [
-                Email::MIME->create(
-                        attributes => {
-                                content_type => 'text/xhtml; charset=UTF-8',
-                                encoding => 'base64',
-                        },
-                        body => $html_body,
-                ),
-                Email::MIME->create(
-                        attributes => {
-                                content_type => 'text/plain',
-                                encoding => 'quoted-printable',
-                        },
-                        body => 'hi = "bye"',
-                )
-        ];
-        Email::MIME->create(
-                header_str => [
-                  From => 'a@example.com',
-                  Subject => 'blah',
-                  'Content-Type' => 'multipart/alternative'
-                ],
-                parts => $parts,
-        )}; # mime_load sub
+        my $email = mime_load 't/filter_base-xhtml.eml';
         is($f->delivery($email), 100, "xhtml rejected");
 }
 
 {
         my $f = PublicInbox::Filter::Base->new;
-        my $email = mime_load 't/filter_base-junk.eml', sub {
-        my $parts = [
-                Email::MIME->create(
-                        attributes => {
-                                content_type => 'application/vnd.ms-excel',
-                                encoding => 'base64',
-                        },
-                        body => 'junk',
-                ),
-                Email::MIME->create(
-                        attributes => {
-                                content_type => 'text/plain',
-                                encoding => 'quoted-printable',
-                        },
-                        body => 'junk',
-                )
-        ];
-        Email::MIME->create(
-                header_str => [
-                  From => 'a@example.com',
-                  Subject => 'blah',
-                  'Content-Type' => 'multipart/mixed'
-                ],
-                parts => $parts,
-        )}; # mime_load sub
+        my $email = mime_load 't/filter_base-junk.eml';
         is($f->delivery($email), 100, 'proprietary format rejected on glob');
 }