gcf2: wire up read-only daemons and rm -gcf2 script

It seems easiest to have a singleton Gcf2Client client object
per daemon worker for all inboxes to use.  This reduces overall
FD usage from pipes.

The `public-inbox-gcf2' command + manpage are gone and a `$^X'
one-liner is used, instead.  This saves inodes for internal
commands and hopefully makes it easier to avoid mismatched
PERL5LIB include paths (as noticed during development :x).

We'll also make the existing cat-file process management
infrastructure more resilient to BOFHs on process killing
sprees (or in case our libgit2-based code fails on us).

(Rare) PublicInbox::WWW PSGI users NOT using public-inbox-httpd
won't automatically benefit from this change, and extra
configuration will be required (to be documented later).

1 files changed, 0 insertions, 31 deletions

diff --git a/script/public-inbox-gcf2 b/script/public-inbox-gcf2
deleted file mode 100755
index 4a44b654..00000000
--- a/script/public-inbox-gcf2
+++ /dev/null
@@ -1,31 +0,0 @@
-#!perl -w
-# Copyright (C) 2020 all contributors <meta@public-inbox.org>
-# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
-eval { require PublicInbox::Gcf2 };
-die "libgit2 development package or Inline::C missing for $0: $@\n" if $@;
-my $gcf2 = PublicInbox::Gcf2::new();
-use IO::Handle; # autoflush
-STDERR->autoflush(1);
-STDOUT->autoflush(1);
-
-while (<STDIN>) {
-        chomp;
-        my ($oid, $git_dir) = split(/ /, $_, 2);
-        $gcf2->add_alternate("$git_dir/objects");
-        if (!$gcf2->cat_oid(1, $oid)) {
-                # retry once if missing.  We only get unabbreviated OIDs
-                # from SQLite or Xapian DBs, here, so malicious clients
-                # can't trigger excessive retries:
-                warn "I: $$ $oid missing, retrying in $git_dir...\n";
-
-                $gcf2 = PublicInbox::Gcf2::new();
-                $gcf2->add_alternate("$git_dir/objects");
-
-                if ($gcf2->cat_oid(1, $oid)) {
-                        warn "I: $$ $oid found after retry\n";
-                } else {
-                        warn "W: $$ $oid missing after retry\n";
-                        print "$oid missing\n"; # mimic git-cat-file
-                }
-        }
-}