diff options
author | Eric Wong <e@yhbt.net> | 2020-01-10 09:14:19 +0000 |
---|---|---|
committer | Eric Wong <e@yhbt.net> | 2020-01-11 06:32:08 +0000 |
commit | 9f5a583694396f84056b9d92255bba0197b52bc8 (patch) | |
tree | efece7a24babf0bfa9ad0f31abab5a119ce384ff /lib/PublicInbox/WwwListing.pm | |
parent | 6d576feb27625abc36675b7b466265d4f06b2f26 (diff) | |
download | public-inbox-9f5a583694396f84056b9d92255bba0197b52bc8.tar.gz |
Most spawn and popen_rd callers die on failure to spawn, anyways, and some are missing checks entirely. This saves us a bunch of verbose error-checking code in callers. This also makes popen_rd more consistent, since it already dies on pipe creation failures.
Diffstat (limited to 'lib/PublicInbox/WwwListing.pm')
-rw-r--r-- | lib/PublicInbox/WwwListing.pm | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm index a52dba11..8d610037 100644 --- a/lib/PublicInbox/WwwListing.pm +++ b/lib/PublicInbox/WwwListing.pm @@ -136,9 +136,7 @@ sub fingerprint ($) { my ($git) = @_; # TODO: convert to qspawn for fairness when there's # thousands of repos - my ($fh, $pid) = $git->popen('show-ref') or - die "popen($git->{git_dir} show-ref) failed: $!"; - + my ($fh, $pid) = $git->popen('show-ref'); my $dig = Digest::SHA->new(1); while (read($fh, my $buf, 65536)) { $dig->add($buf); |