diff options
| author | Eric Wong <e@80x24.org> | 2022-09-10 08:17:28 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2022-09-10 19:50:57 +0000 |
| commit | 4981c5c7940ca0a7b669fd4c5b8338bdd6cee710 (patch) | |
| tree | e58d784a6893b57869cf61c79c54c3538e34791f /lib/PublicInbox/WwwListing.pm | |
| parent | 0befaaa7b1ed2015fb5d6bf159db7d8972015f58 (diff) | |
| download | public-inbox-4981c5c7940ca0a7b669fd4c5b8338bdd6cee710.tar.gz | |
Again, ->deflate (and thus ->zmore) calls are relatively expensive compared to `print' ops using PerlIO::scalar behind-the-scenes. While I can likely optimize the `join' away here, too, that will happen in a future commit.
Diffstat (limited to 'lib/PublicInbox/WwwListing.pm')
| -rw-r--r-- | lib/PublicInbox/WwwListing.pm | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm index 35abf050..72c940dd 100644 --- a/lib/PublicInbox/WwwListing.pm +++ b/lib/PublicInbox/WwwListing.pm @@ -208,27 +208,28 @@ sub psgi_triple { my $h = [ 'Content-Type', 'text/html; charset=UTF-8', 'Content-Length', undef ]; my $gzf = gzf_maybe($h, $ctx->{env}); - $gzf->zmore('<html><head><title>public-inbox listing</title>' . - $ctx->{www}->style('+/') . - '</head><body>'); + my $zfh = $gzf->zfh; + print $zfh '<html><head><title>public-inbox listing</title>', + $ctx->{www}->style('+/'), + '</head><body>'; my $code = 404; if (my $list = delete $ctx->{-list}) { my $mset = delete $ctx->{-mset}; $code = 200; if ($mset) { # already sorted, so search bar: - $gzf->zmore(mset_nav_top($ctx, $mset)); + print $zfh mset_nav_top($ctx, $mset); } else { # sort config dump by ->modified @$list = map { $_->[1] } sort { $b->[0] <=> $a->[0] } @$list; } - $gzf->zmore('<pre>', join("\n", @$list)); # big - $gzf->zmore(mset_footer($ctx, $mset)) if $mset; + print $zfh '<pre>', join("\n", @$list); # big + print $zfh mset_footer($ctx, $mset) if $mset; } elsif (my $mset = delete $ctx->{-mset}) { - $gzf->zmore(mset_nav_top($ctx, $mset) . - '<pre>no matching inboxes' . - mset_footer($ctx, $mset)); + print $zfh mset_nav_top($ctx, $mset), + '<pre>no matching inboxes', + mset_footer($ctx, $mset); } else { - $gzf->zmore('<pre>no inboxes, yet'); + print $zfh '<pre>no inboxes, yet'; } my $out = $gzf->zflush('</pre><hr><pre>'. qq(This is a listing of public inboxes, see the `mirror' link of each inbox |