view: attach_link uses string concatentation

There is no point in using an array to join on an
empty string (my original intention was probably to
join on "\n").

This is only preparation for the next change to show
a warning to in the attachment link.

1 files changed, 3 insertions, 3 deletions

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 6f79f601..30572216 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -427,10 +427,10 @@ sub attach_link ($$$$) {
         } else {
                 $sfn = 'a.bin';
         }
-        my @ret = qq($nl<a\nhref="$upfx$idx-$sfn">[-- Attachment #$idx: );
+        my $ret = qq($nl<a\nhref="$upfx$idx-$sfn">[-- Attachment #$idx: );
         my $ts = "Type: $ct, Size: $size bytes";
-        push(@ret, ($desc eq '') ? "$ts --]" : "$desc --]\n[-- $ts --]");
-        join('', @ret, "</a>\n");
+        $ret .= ($desc eq '') ? "$ts --]" : "$desc --]\n[-- $ts --]";
+        $ret .= "</a>\n";
 }
 
 sub add_text_body {