diff options
author | Eric Wong <e@80x24.org> | 2019-09-12 08:34:21 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-09-14 09:24:27 +0000 |
commit | 25c41ff78d0a65029e410b5478430b1061df1dae (patch) | |
tree | 5fdc86205b9e62d5c9b80a12b4bb34ad2f7378e7 /lib/PublicInbox/Tmpfile.pm | |
parent | e5631087d3862823d0d4854a8dfc1258f91cb115 (diff) | |
download | public-inbox-25c41ff78d0a65029e410b5478430b1061df1dae.tar.gz |
Might as well share some code for temporary file creation
Diffstat (limited to 'lib/PublicInbox/Tmpfile.pm')
-rw-r--r-- | lib/PublicInbox/Tmpfile.pm | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/PublicInbox/Tmpfile.pm b/lib/PublicInbox/Tmpfile.pm index 7fda100e..28e87f88 100644 --- a/lib/PublicInbox/Tmpfile.pm +++ b/lib/PublicInbox/Tmpfile.pm @@ -12,10 +12,9 @@ require File::Spec; # use tmpfile instead of open(..., '+>', undef) so we can get an # unlinked filename which makes sense when viewed with lsof # (at least on Linux) -# TODO: O_APPEND support (this is the reason I'm not using File::Temp) # And if we ever stop caring to have debuggable filenames, O_TMPFILE :) -sub tmpfile ($;$) { - my ($id, $sock) = @_; +sub tmpfile ($;$$) { + my ($id, $sock, $append) = @_; if (defined $sock) { # add the socket inode number so we can figure out which # socket it belongs to @@ -25,10 +24,11 @@ sub tmpfile ($;$) { $id =~ tr!/!^!; my $fl = O_RDWR | O_CREAT | O_EXCL; + $fl |= O_APPEND if $append; do { my $fn = File::Spec->tmpdir . "/$id-".time.'-'.rand; if (sysopen(my $fh, $fn, $fl, 0600)) { # likely - unlink($fn) or die "unlink($fn): $!"; # FS broken + unlink($fn) or warn "unlink($fn): $!"; # FS broken return $fh; # success } } while ($! == EEXIST); |