about summary refs log tree commit homepage
path: root/lib/PublicInbox/SpawnPP.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-02-07 08:51:43 +0000
committerEric Wong <e@80x24.org>2021-02-07 22:56:52 +0000
commit975dffc9bcb96f10bdc8a70bf6af67c2b46ab4b5 (patch)
tree1161b13fda37a034bbd570296b7e13a12a2dd60f /lib/PublicInbox/SpawnPP.pm
parent17b960feb2362af29848cdac7548197bcccb3ff7 (diff)
downloadpublic-inbox-975dffc9bcb96f10bdc8a70bf6af67c2b46ab4b5.tar.gz
We continue to unblock SIGCHLD unconditionally, but also
any signals not blocked by the parent (wq_worker).

This will allow Ctrl-C (SIGINT) to stop "git clone" and allow
git-clone cleanup to be performed and other long-running
processes when pi_fork_exec supports setpgid(2).  This won't
affect existing daemons on systems with signalfd(2) or
EVFILT_SIGNAL at all, since those run with signals blocked
anyways.
Diffstat (limited to 'lib/PublicInbox/SpawnPP.pm')
-rw-r--r--lib/PublicInbox/SpawnPP.pm6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/PublicInbox/SpawnPP.pm b/lib/PublicInbox/SpawnPP.pm
index b0ad4da5..f64b95dc 100644
--- a/lib/PublicInbox/SpawnPP.pm
+++ b/lib/PublicInbox/SpawnPP.pm
@@ -37,10 +37,8 @@ sub pi_fork_exec ($$$$$$) {
                         chdir $cd or die "chdir $cd: $!";
                 }
                 $SIG{$_} = 'DEFAULT' for keys %SIG;
-                my $cset = POSIX::SigSet->new();
-                $cset->addset(POSIX::SIGCHLD) or die "can't add SIGCHLD: $!";
-                sigprocmask(SIG_UNBLOCK, $cset) or
-                                        die "can't unblock SIGCHLD: $!";
+                $old->delset(POSIX::SIGCHLD) or die "delset SIGCHLD: $!";
+                sigprocmask(SIG_SETMASK, $old) or die "SETMASK: ~SIGCHLD: $!";
                 if ($ENV{MOD_PERL}) {
                         exec which('env'), '-i', @$env, @$cmd;
                         die "exec env -i ... $cmd->[0] failed: $!\n";