diff options
| author | Eric Wong <e@80x24.org> | 2023-11-02 09:35:30 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2023-11-03 06:39:28 +0000 |
| commit | d3c55d072839286efb2865fe20f2324a9e595e95 (patch) | |
| tree | c3a7b450e22a0e9d7e849d53884f6af8af19cee5 /lib/PublicInbox/Spawn.pm | |
| parent | 19f9089343c9e579253db756f2131ee493718ead (diff) | |
| download | public-inbox-d3c55d072839286efb2865fe20f2324a9e595e95.tar.gz | |
treewide: use ->close to call ProcessIO->CLOSE
This will open the door for us to drop `tie' usage from ProcessIO completely in favor of OO method dispatch. While OO method dispatches (e.g. `$fh->close') are slower than normal subroutine calls, it hardly matters in this case since process teardown is a fairly rare operation and we continue to use `close($fh)' for Maildir writes.
Diffstat (limited to 'lib/PublicInbox/Spawn.pm')
| -rw-r--r-- | lib/PublicInbox/Spawn.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm index e7d2c6ea..b4f37bea 100644 --- a/lib/PublicInbox/Spawn.pm +++ b/lib/PublicInbox/Spawn.pm @@ -421,7 +421,7 @@ sub run_qx { local $/; $ret[0] = <$fh>; } - close $fh; # caller should check $? + $fh->close; # caller should check $? read_out_err($opt); wantarray ? @ret : $ret[0]; } |