spawn: remove support for clearing the env

It's unnecessary code which I'm not sure we ever used.  In
retrospect, completely clearing the environment doesn't make
sense for the processes we spawn.  We don't need to clobber
individual environment variables in our code, either
(and if we did for tests, we can use 'local').

1 files changed, 1 insertions, 11 deletions

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index b946a663..6493ad38 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -193,17 +193,7 @@ sub spawn ($;$$) {
         my @env;
         $opts ||= {};
 
-        my %env = $opts->{-env} ? () : %ENV;
-        if ($env) {
-                foreach my $k (keys %$env) {
-                        my $v = $env->{$k};
-                        if (defined $v) {
-                                $env{$k} = $v;
-                        } else {
-                                delete $env{$k};
-                        }
-                }
-        }
+        my %env = $env ? (%ENV, %$env) : %ENV;
         while (my ($k, $v) = each %env) {
                 push @env, "$k=$v";
         }